Skip to content

Add DisProt features - #213

Draft
CLPF wants to merge 6 commits into
MICommunity:masterfrom
CLPF:master
Draft

Add DisProt features#213
CLPF wants to merge 6 commits into
MICommunity:masterfrom
CLPF:master

Conversation

@CLPF

@CLPF CLPF commented Jul 16, 2026

Copy link
Copy Markdown
  • Fix annotation fetching not trigerring render
  • Add disorder features
  • Add AlphaFold track
  • Add transition and functional information inside features

@colin-combe

colin-combe commented Jul 30, 2026

Copy link
Copy Markdown

Hi,
thanks for your contribution,
I'm not sure about ef2ab18

it would cause re-rendering annotations and the key after every protein's individual annotation load rather than when they have all loaded?

Colin

@EliotRagueneau

Copy link
Copy Markdown

Hi @colin-combe , that commit actually comes from me.

originally as you incremented the counter once per annotation group, you would reach a total of n annotation group * p proteins, e.g. 10 proteins and 2 annotations (superFam and Unitprot) would lead to a total counter of 20, but you would only trigger the rendering midway through, let's say when all superfam have been processed, or 5 superfam and 5 uniprot.

We noticed this issue while adding DisProt because they were never being rendered with the current system.

With the proposed commit, once one "track" has fully loaded all its proteins, we render it.

We could also wait for all the annotations from all the resources to be loaded before rendering them, but then you risk having uniprot features not being displayed if superFam is not working for instance, or just taking a long time to resolve.

@colin-combe

Copy link
Copy Markdown

@EliotRagueneau - right, i see now it was broken.

With the proposed commit, once one "track" has fully loaded all its proteins, we render it.

Is that the behaviour now? Or is the protsAnnotated++ counter now redundant and it renders every time a request returns (after all requests have been sent)?

cheers,
Col

@EliotRagueneau

Copy link
Copy Markdown

Is that the behaviour now? Or is the protsAnnotated++ counter now redundant and it renders every time a request returns (after all requests have been sent)?

Well we only trigger the callback once the counter reach the number of proteins, on the last callback after annotations have been created, so yeah, basically when the last protein have received back it's annotation from Uniprot, then we render everything. When the last protein received its annotations from SupFam, we render. The counter is actually important to keep track on whether we received the last protein or not 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants