Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unreclaimed historical signatures cause quadratic memory growth on linear-size inputs.
1 open finding
What changed in this PR
Adds dirty-state tracking to inductive weak bisimulation, limiting signature recomputation before partition splitting.
Changes:
- Implements dirty-state refinement with regression and randomized tests.
- Generalizes signature helpers for persistent storage.
- Routes reduction and comparison through the new algorithm while retaining naive variants.
| File | Description |
|---|---|
| crates/reduction/src/signatures.rs | Generalizes signature inputs using AsRef. |
| crates/reduction/src/signature_refinement.rs | Adds dirty-state refinement and tests. |
| crates/reduction/src/reduce.rs | Adds algorithm variants and updates reduction dispatch. |
| crates/reduction/src/compare.rs | Updates comparison dispatch for both variants. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+747
to
+750
| let signature: OwnedSignature = Rc::from(builder.as_slice()); | ||
| let key = key_to_signature.len(); | ||
| id.insert(signature.clone(), key); | ||
| key_to_signature.push(signature); |
mlaveaux
force-pushed
the
feature/weak-bisim-inductive
branch
from
November 6, 2026 15:24
9653443 to
581a67a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added an inductive weak bisimulation variant that uses marked dirty states to only update required signatures before splitting. Benchmarks show that this does work for some examples in the VLTS benchmark set.