chore(deps): roll up lumera devnet grpc bump - #217
Open
j-rafique wants to merge 1 commit into
Open
Conversation
j-rafique
force-pushed
the
chore/devnet-grpc-rollup
branch
from
September 9, 2026 17:29
58e8d2a to
7c1b85a
Compare
j-rafique
force-pushed
the
chore/devnet-grpc-rollup
branch
from
September 9, 2026 17:34
7c1b85a to
93affac
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new govulncheck baseline script currently ignores govulncheck execution failures, which can cause false-negative CI passes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the devnet Go module dependencies (notably google.golang.org/grpc) and tightens CI security scanning by introducing a govulncheck baseline wrapper that allows only explicitly reviewed, currently-unfixed reachable vulnerability IDs.
Changes:
- Added
scripts/govulncheck-baseline.shand updated thegovulncheckGitHub Action to use it. - Bumped devnet dependencies (grpc + assorted
golang.org/x/*, OpenTelemetry, genproto) and updated the devnetgodirective. - Made the consensus determinism workflow’s
jqinstallation conditional.
File summaries
| File | Description |
|---|---|
| scripts/govulncheck-baseline.sh | Adds a baseline allowlist wrapper that parses govulncheck JSON output and fails on new/actionable reachable vulnerabilities. |
| .github/workflows/govulncheck.yml | Switches CI to use the new baseline wrapper script for actionable vulnerability gating. |
| devnet/go.mod | Updates devnet module Go version and bumps grpc + related dependency versions. |
| devnet/go.sum | Synchronizes go.sum with the devnet dependency bumps. |
| .github/workflows/consensus-determinism.yml | Ensures jq is present without always running apt installs. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+38
to
+43
| set +e | ||
| ( | ||
| cd "$module" | ||
| govulncheck -format=json "$@" ./... > "$out" | ||
| ) | ||
| set -e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.