Repository navigation
Resolve constant-reference dependencies and safely inferred import paths - #56
Open
TristanKruse wants to merge 6 commits into
Open
TristanKruse wants to merge 6 commits into
TristanKruse wants to merge 6 commits into
Conversation
TristanKruse
changed the base branch from
main
to
fix/definition-of-done-blockers
October 16, 2026 17:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoloaded code such as
Retrieval::Store.newand imports such aspath = '../retrieval/store'; require_relative pathpreviously contributed no architecture dependency. Both issue reproducers now produce the expected single forbidden file dependency without executing application code.CheckOptions.new(dependency_analysis: :imports_and_constants)with a bounded Prism definition/reference index. Import-only analysis remains the default. Lexical nesting, compact/root-qualified namespaces, namespace shadowing, and explicit superclass/mixin references are covered; ambiguous reopenings and unsupported lookup stay unresolved.This PR is based on
fix/definition-of-done-blockers(#51), keeping the extraction diff separate from its documentation/quality prerequisites. Review and merge #51 first, then retarget this PR tomainif GitHub has not done so automatically. The overlapping changelog, CheckOptions, and metric-documentation edits have already been resolved together. Both PRs include the merged documentation and debug-inspection changes (#52 and #53); no gem release is triggered.The combined branch passes 499 examples with zero failures on Ruby 4.0.6 / Windows x64, with 98.98% line and 90.94% branch coverage. RuboCop checks 248 files with no offenses, 176 generated documentation pages and their links validate, and the strict 0.0.2 gem build plus installed-gem reproducers pass. One existing symlink example is skipped because this Windows account cannot create symlinks. The GitHub matrix additionally verifies Ruby 3.3/3.4 on Ubuntu and 4.0 on Windows, plus the RAG fixture and installed-gem reproducers.
Three fresh-process 1,000-file benchmark runs per mode: median cold graph build 1.706 s import-only vs 1.533 s expanded; median constant indexing 32.0 ms. Filesystem/run-order noise prevents interpreting the total-time difference as a speedup. All warm checks reuse the graph. Memory samples and their GC-related limits are recorded in benchmark/README.md.
Closes #54
Closes #55