Skip to content

Make code more pythonic - #75

Merged
Luctia merged 2 commits into
Luctia:mainfrom
canepan:main
Dec 29, 2025
Merged

Make code more pythonic#75
Luctia merged 2 commits into
Luctia:mainfrom
canepan:main

Conversation

@canepan

@canepan canepan commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the codebase to follow more pythonic conventions and patterns. The changes improve code readability and maintainability by adopting modern Python idioms and better code organization.

Key changes include:

  • Wrapping main execution code in a main() function with proper if __name__ == '__main__' guard
  • Replacing string concatenation with f-strings throughout the codebase
  • Replacing list.__contains__() calls with the more pythonic in operator
  • Improving UID retrieval by using pwd and getpass modules instead of shell command execution

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
main.py Refactored main script by wrapping code in a main() function, adding __main__ guard, replacing .__contains__() with in operator, and adding optional display name parameter to take_input() function
container_configs.py Replaced all string concatenations with f-strings for cleaner string formatting, added imports for getpass and pwd modules, and improved UID retrieval using pwd.getpwnam() instead of shell command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread main.py Outdated
Comment thread main.py
for service in services:
try:
getattr(permission_setup, service)()
except AttributeError:

Copilot AI Dec 28, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'except' clause does nothing but pass and there is no explanatory comment.

Suggested change
except AttributeError:
except AttributeError:
# Some services do not have a corresponding permission/folder setup method;
# missing attributes here are expected and can be safely ignored.

Copilot uses AI. Check for mistakes.
Comment thread main.py
print('Where would you like to keep your files?', end=' ')
root_dir = take_directory_input()

compose = open('docker-compose.yml', 'w')

Copilot AI Dec 28, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File may not be closed if this operation raises an exception.
File may not be closed if this operation raises an exception.

Copilot uses AI. Check for mistakes.
@Luctia
Luctia merged commit 700830e into Luctia:main Dec 29, 2025
1 check failed
@Luctia

Luctia commented Dec 29, 2025

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants