Skip to content

Reinstalled packages for only development as dev-dependencies - #328

Closed
tomoki-oke-LITALICO wants to merge 1 commit into
LucasBassetti:masterfrom
tomoki-oke-LITALICO:fix/dev-deps-or-deps-for-package-vulnerability
Closed

tomoki-oke-LITALICO wants to merge 1 commit into
LucasBassetti:masterfrom
tomoki-oke-LITALICO:fix/dev-deps-or-deps-for-package-vulnerability

Conversation

@tomoki-oke-LITALICO

@tomoki-oke-LITALICO tomoki-oke-LITALICO commented Jan 25, 2022 •

Copy link
Copy Markdown

close: #327

Reinstalled packages for only development as dev-dependencies.

@tomoki-oke-LITALICO tomoki-oke-LITALICO changed the title Specify dependencies for only the packages on need to use Reinstalled packages for only development as dev-dependencies. Jan 25, 2022
@tomoki-oke-LITALICO tomoki-oke-LITALICO changed the title Reinstalled packages for only development as dev-dependencies. Reinstalled packages for only development as dev-dependencies Jan 25, 2022
@LucasBassetti

Copy link
Copy Markdown
Owner

Thanks for this PR! The dev-only packages were moved to devDependencies, together with react/react-dom, which were also wrongly installed as dependencies.

It is covered by #392, which updates the whole toolchain and fixes these issues, so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reinstall packages for only development as dev-dependencies

2 participants