Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ping feature currently mixes event handling, process execution, statistics, persistence and rendering in App and UI. This makes new tabs expensive to add.
This refactor introduces a small Component contract and a single registration point, separates Ping state/input/rendering/history from the Linux network backend, and uses Tokio and tui-input for background work and text editing. Existing recent targets remain compatible. It adds typed ping outcomes, process deadlines, terminal cleanup, regression tests and a runnable third-tab extension example.
Compiled extensions are supported through Component; runtime plugin loading is intentionally deferred until there is a concrete external-plugin use case.
Validation is in progress through the included GitHub Actions workflow. Local Rust tooling is unavailable in the editing environment. This draft targets feature/ping and is not intended to be merged until validation is complete.