Skip to content

Feat: Make every row without a PDB - #228

Merged
b-re-w merged 4 commits into
developfrom
feat/no-pdb
Nov 14, 2026
Merged

b-re-w merged 4 commits into
developfrom
feat/no-pdb

Conversation

@b-re-w

@b-re-w b-re-w commented Nov 14, 2026

Copy link
Copy Markdown
Member

Rivet no longer downloads or reads a browser's debug symbols, in the runtime or in CI row generation. Every row is made from the verified prior row, its fingerprints, the prior build's module and the new build's module. Rows already verified with symbols stay as the starting point.

Commits

  1. Make every row without a PDB. Removes fetch-symbols.ps1, the symbol download and PDB recheck steps of browser-rows.yml, the name based port (port_row, check_against_pdb, differences_from_pdb_row, the made_without_pdb mark), pdb-key, extract, names, near, the DbgHelp code, PeFile::pdb_key, the PDB keys in rows/table.json, row-port.ps1 and the runtime test that required a PDB key. chrome-builds find now takes the prior module and the row job always fetches the prior build. A vouched row is fingerprinted from its own module, and a row that needs review gets none.
  2. Read class names from the prior build. row_class::class_name_of_table reads a class table's views class name back from the module (constructor, MetaDataProvider table, metadata static, the name its filling code loads) and keeps it only where class_tables gives exactly that table. New rows record the names under classes by value path, and a recorded name is confirmed again before use.
  3. scripts/tests/no-pdb.test.sh. Fails if tracked code, scripts or workflows name a symbol server or hold PDB reading code. Runs from scripts/check.sh.
  4. Scoring against answer keys. chrome-builds score and scripts/tests/row-score.ps1 make a row from an older verified row and compare it value by value with the build's verified row: per feature, found and equal, found but different (fails), off. browser-rows.yml runs it with the score dispatch input; that run makes, publishes, proposes and reports nothing.

The NFR-6 rules stay: features whose values are not found are off, and the frame and page area parts that cannot be off still stop the row.

Not verified

Nothing was built or run in the worktree. cargo build, cargo test, cargo clippy and the score run need to happen on develop after merge. Class name reading has only a synthetic module test so far; how many tables it names in real Chrome, Edge and Brave modules, and how long it takes, is unmeasured.

🤖 Generated with Claude Code

b-re-w and others added 4 commits November 15, 2026 06:33
Rivet no longer downloads or reads a browser's debug symbols. Every row is
made the way rows of builds without a published PDB were made: from the
verified prior row, its fingerprints, the prior build's module and the new
build's module. The rows already verified with symbols stay as the
starting point.

- chrome-builds: remove the name based port, the PDB recheck, pdb-key,
  extract, names, near and the DbgHelp code. find now takes the prior
  module instead of the prior PDB, which it always needs.
- row_port: remove port_row, the symbol naming and folding helpers, the
  made_without_pdb mark and its comparison. A prior row without
  screen_origin gives a row without it.
- PeFile no longer reads the CodeView record, and the table no longer
  keeps PDB keys.
- browser-rows.yml: fetch the prior build instead of symbols, and drop
  the steps that waited for a PDB to compare against it. A row that
  needs review gets no fingerprints; a vouched row is fingerprinted from
  its own module as before.
- Remove fetch-symbols.ps1 and row-port.ps1, which needed PDBs.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The generator took the views class of each class table from the prior
PDB's vtable symbols. It now reads the name back from the prior module:
the constructors that write the table at an object's start also write the
ui::metadata provider table, whose GetClassMetaData returns the class's
metadata static, and the code that fills that static loads the class
name BEGIN_METADATA gives. A name counts only where class_tables gives
exactly this table for it in the prior module, so a wrong name gives
none.

Each new row records the names of the class tables it placed under
"classes", by the path of the value, so the next row starts from them.
A recorded name is confirmed the same way before it is used. The runtime
reads only frame and build, so the record changes nothing in a browser.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ad a PDB

scripts/tests/no-pdb.test.sh searches the tracked code, scripts and
workflows for symbol server addresses and for code that reads PDBs
(DbgHelp, DIA, CodeView records, the pdb crate, PDB file names). A search
that cannot run fails rather than passing. check.sh runs it with the
other repository checks, so every pull request runs it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
chrome-builds score makes the row of a build that already has a verified
row from an older verified row, the same way the row job makes rows, and
compares the two value by value. Per feature it reports values found and
equal, values found but different, and whether the made row turns the
feature off because its values were not found. Values the made row leaves
out or does not read in that build are listed as not held. It exits 5
when any value it found is wrong.

scripts/tests/row-score.ps1 runs it over pairs of builds, fetching each
build or reading it from a folder, and fails on any wrong value or when
no pair could be scored. browser-rows.yml runs it when started by hand
with the score input; that run makes no row and publishes, proposes and
reports nothing.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@b-re-w
b-re-w merged commit c6a328e into develop Nov 14, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant