Repository navigation
Feat: Make every row without a PDB - #228
Merged
Merged
Conversation
Rivet no longer downloads or reads a browser's debug symbols. Every row is made the way rows of builds without a published PDB were made: from the verified prior row, its fingerprints, the prior build's module and the new build's module. The rows already verified with symbols stay as the starting point. - chrome-builds: remove the name based port, the PDB recheck, pdb-key, extract, names, near and the DbgHelp code. find now takes the prior module instead of the prior PDB, which it always needs. - row_port: remove port_row, the symbol naming and folding helpers, the made_without_pdb mark and its comparison. A prior row without screen_origin gives a row without it. - PeFile no longer reads the CodeView record, and the table no longer keeps PDB keys. - browser-rows.yml: fetch the prior build instead of symbols, and drop the steps that waited for a PDB to compare against it. A row that needs review gets no fingerprints; a vouched row is fingerprinted from its own module as before. - Remove fetch-symbols.ps1 and row-port.ps1, which needed PDBs. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The generator took the views class of each class table from the prior PDB's vtable symbols. It now reads the name back from the prior module: the constructors that write the table at an object's start also write the ui::metadata provider table, whose GetClassMetaData returns the class's metadata static, and the code that fills that static loads the class name BEGIN_METADATA gives. A name counts only where class_tables gives exactly this table for it in the prior module, so a wrong name gives none. Each new row records the names of the class tables it placed under "classes", by the path of the value, so the next row starts from them. A recorded name is confirmed the same way before it is used. The runtime reads only frame and build, so the record changes nothing in a browser. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ad a PDB scripts/tests/no-pdb.test.sh searches the tracked code, scripts and workflows for symbol server addresses and for code that reads PDBs (DbgHelp, DIA, CodeView records, the pdb crate, PDB file names). A search that cannot run fails rather than passing. check.sh runs it with the other repository checks, so every pull request runs it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
chrome-builds score makes the row of a build that already has a verified row from an older verified row, the same way the row job makes rows, and compares the two value by value. Per feature it reports values found and equal, values found but different, and whether the made row turns the feature off because its values were not found. Values the made row leaves out or does not read in that build are listed as not held. It exits 5 when any value it found is wrong. scripts/tests/row-score.ps1 runs it over pairs of builds, fetching each build or reading it from a folder, and fails on any wrong value or when no pair could be scored. browser-rows.yml runs it when started by hand with the score input; that run makes no row and publishes, proposes and reports nothing. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rivet no longer downloads or reads a browser's debug symbols, in the runtime or in CI row generation. Every row is made from the verified prior row, its fingerprints, the prior build's module and the new build's module. Rows already verified with symbols stay as the starting point.
Commits
fetch-symbols.ps1, the symbol download and PDB recheck steps ofbrowser-rows.yml, the name based port (port_row,check_against_pdb,differences_from_pdb_row, themade_without_pdbmark),pdb-key,extract,names,near, the DbgHelp code,PeFile::pdb_key, the PDB keys inrows/table.json,row-port.ps1and the runtime test that required a PDB key.chrome-builds findnow takes the prior module and the row job always fetches the prior build. A vouched row is fingerprinted from its own module, and a row that needs review gets none.row_class::class_name_of_tablereads a class table's views class name back from the module (constructor,MetaDataProvidertable, metadata static, the name its filling code loads) and keeps it only whereclass_tablesgives exactly that table. New rows record the names underclassesby value path, and a recorded name is confirmed again before use.scripts/tests/no-pdb.test.sh. Fails if tracked code, scripts or workflows name a symbol server or hold PDB reading code. Runs fromscripts/check.sh.chrome-builds scoreandscripts/tests/row-score.ps1make a row from an older verified row and compare it value by value with the build's verified row: per feature, found and equal, found but different (fails), off.browser-rows.ymlruns it with thescoredispatch input; that run makes, publishes, proposes and reports nothing.The NFR-6 rules stay: features whose values are not found are off, and the frame and page area parts that cannot be off still stop the row.
Not verified
Nothing was built or run in the worktree.
cargo build,cargo test,cargo clippyand the score run need to happen on develop after merge. Class name reading has only a synthetic module test so far; how many tables it names in real Chrome, Edge and Brave modules, and how long it takes, is unmeasured.🤖 Generated with Claude Code