Repository navigation
Fix: Wait for Brave's install wherever its installer puts it - #226
Merged
Merged
Conversation
Brave 158's silent installer exited with 0 but no browser was under Program Files when the row job looked, so both Brave 158 builds failed before a row was made. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brave 158's silent installer exited with 0 but nothing was under Program Files when the row job looked, so both Brave 158 builds failed before a row was made. The script now checks the machine, 32 bit and user install places and waits up to 10 minutes for the build's own version folder.
Verified: trial run 43638307436 made the row for Brave 158.1.100.56 (job succeeded).
🤖 Generated with Claude Code