Skip to content

Feat: Move public and derivable values off the row and turn off features per build - #220

Merged
b-re-w merged 4 commits into
developfrom
feat/rows-reflect
Nov 14, 2026
Merged

b-re-w merged 4 commits into
developfrom
feat/rows-reflect

Conversation

@b-re-w

@b-re-w b-re-w commented Nov 14, 2026

Copy link
Copy Markdown
Member

Implements part of NFR-6 in the D16 order. A milestone change no longer sends a whole row to review because of carried values. Public command ids and a view's parent and children fields leave the row. Rivet's own choices become settings. A value that only one feature reads now turns that feature off for that build, with the runtime's existing switch.

Nothing was built, tested or run in this worktree. The owner builds on develop after the merge.

Commits

  1. Feat: Take the developer bar commands from Chromium's public command ids (A). rivet/platform/windows/src/command_ids.rs holds IDC_DEV_TOOLS_INSPECT (40023) and IDC_DEV_TOOLS_CONSOLE (40005). Both were read from chrome/app/chrome_command_ids.h at branches 7871 to 8154 (Chromium 150 to 159). The runtime takes them by milestone (browsers::chromium::commands::dev_tools). DevMode no longer has inspect/console. The generator writes them from the table, or 0 for an unread milestone, and does not carry them.
  2. Feat: Turn off only the features whose row values could not be read. See below.
  3. Feat: Take a view's parent and children fields from its bounds offset (B). In ui/views/view.h, parent_ comes 0x30 before bounds_, and children_ comes right after parent_. Every compiled row agrees with this (test nfr6_a_views_parent_and_children_are_not_row_values). The reflect.rs walk finds the same pair at run time. The runtime takes both from layout.view_bounds_offset. The generator writes them from it (row_recipe::FOLLOWS).
  4. Feat: Keep Rivet's toolbar lead and top inset adjustment as settings (D).

Per feature switch-off (NFR-6)

rivet/platform/windows/src/row_features.rs maps each row value to the feature that alone reads it. It reuses the switches the runtime already obeys:

Feature Switch in the row Values Feature checks excused
split view split.supported = false all of split.* split, split-*
vertical tabs vertical.supported = false update_collapse_action, browser_offset, mode_offset, width_offset none
sidebar side_panel.supported = false color_source, source_in_widget, entry_count, extension_entry, features_*, hidden_entries, and the layout fields only the Sidebar reads (side_panel, side_panel_animation, contents_outline, vertical_tabs, set to ABSENT) sidebar, sidebar-*, fullscreen-sidebar
app window app_window = null all of app_window.* mini-*, tab-moves
address suggestions omnibox = null all of omnibox.* address-suggest, security-chip
developer colours toolbar.dev.colours = [] the colour ids dev-row
frame colour layout.provider_verified = false frame_ids, caption_ink_ids none

When the generator must check carried values (a milestone changed, or values were read from the prior build next to the new one), settle_carried does the following:

  • A value the build does not read is written as zero. tabs.tab_collection and tabs.tab_contents are unread while tab_at is recorded. The window feature values are unread while vertical.window_feature is absent.
  • A feature value is cleared and its feature is turned off. The row lists it under switched_off, and the report under switched_off.
  • Any other value still stops the row, with its reason.

chrome-builds gate <results> <browser> <row.json> does not require the checks of a switched-off feature, and prints a note for each. The workflow passes the row. Every other check must still pass. A draft PR body now also lists the switched-off features.

I checked every reader of the switched values. Split view hooks install only when checked(). Sidebar colours and page area reads run only when the Sidebar is checked and the rail is open. The app layout slot is read only with the omnibox part.

Classification of carried values

Classes: A is a public stable surface, B is name or source-layout reflection, C needs a build recipe (D16 point 3), and D is a Rivet setting.

Union of the three reports: 102 carried paths (list items counted one by one). A 2, B 19, C 79, D 2.

Value Class Public source path In this PR
app_window.bounds_changed_slot C turns app window off
app_window.browser_type C turns app window off
app_window.destructor_slot C turns app window off
app_window.view_children B views::View::children_, right after parent_ in ui/views/view.h off the row
app_window.view_parent B views::View::parent_, 0x30 before bounds_ in ui/views/view.h; the reflect.rs walk finds the same pair off the row
layout.browser_window_in_view C still stops the row
layout.caption_container_offset B BrowserFrameViewWin child BrowserCaptionButtonContainer by class name still stops the row (reflection path not built)
layout.caption_ink_ids C turns frame colour off
layout.caption_ink_ids[0] C turns frame colour off
layout.caption_ink_ids[1] C turns frame colour off
layout.caption_ink_ids[2] C turns frame colour off
layout.frame_browser_window_offset B frame view field pointing into the view named BrowserView still stops the row (reflection path not built)
layout.frame_ids C turns frame colour off
layout.frame_ids[0] C turns frame colour off
layout.frame_ids[1] C turns frame colour off
layout.frame_ids[3] C turns frame colour off
layout.frame_ids[4] C turns frame colour off
layout.frame_ids[5] C turns frame colour off
layout.top_inset_adjust D DIPs Rivet chooses a setting
layout.view_bounds_offset B views::View metadata property Bounds still stops the row (reflection path not built)
omnibox.app_layout_slot C turns address suggestions off
omnibox.controller_published_result C turns address suggestions off
omnibox.controller_size C turns address suggestions off
omnibox.input_omit_asynchronous C turns address suggestions off
omnibox.input_prevent_inline C turns address suggestions off
omnibox.input_size C turns address suggestions off
omnibox.match_contents C turns address suggestions off
omnibox.match_description C turns address suggestions off
omnibox.match_destination C turns address suggestions off
omnibox.match_size C turns address suggestions off
omnibox.provider_client_size C turns address suggestions off
omnibox.scheme_classifier_size C turns address suggestions off
side_panel.color_source C turns sidebar off
side_panel.contents_container B layout field naming MultiContentsView / ContentsContainerView by class name still stops the row (reflection path not built)
side_panel.contents_outline B layout field naming the contents outline view by class name turns sidebar off (reflection path not built)
side_panel.entry_count C turns sidebar off
side_panel.extension_entry C turns sidebar off
side_panel.features_coordinator C turns sidebar off
side_panel.features_offset C turns sidebar off
side_panel.hidden_entries[0] C turns sidebar off
side_panel.host_view B layout field naming the view whose ui::metadata class is BrowserView still stops the row (reflection path not built)
side_panel.page_area B layout field naming the page area view by class name (browser_view_layout.h) still stops the row (reflection path not built)
side_panel.side_panel B layout field naming SidePanel by class name turns sidebar off (reflection path not built)
side_panel.side_panel_animation B layout field naming the side panel animation content by class name turns sidebar off (reflection path not built)
side_panel.source_in_widget C turns sidebar off
side_panel.toolbar B layout field naming ToolbarView by class name still stops the row (reflection path not built)
side_panel.vertical_tabs B layout field naming VerticalTabStripRegionView by class name turns sidebar off (reflection path not built)
split.active_member C turns split view off
split.container_count_member B the same vector turns split view off (reflection path not built)
split.container_delegate_offset C turns split view off
split.containers_member B MultiContentsView vector of ContentsContainerView by class name (multi_contents_view.h) turns split view off (reflection path not built)
split.flex_layout_host C turns split view off
split.layout_delegate_offset C turns split view off
split.mini_toolbar_member B ContentsContainerView child MultiContentsViewMiniToolbar by class name turns split view off (reflection path not built)
split.outline_member B ContentsContainerView outline child by class name turns split view off (reflection path not built)
split.set_border_slot C turns split view off
split.set_visible_slot B views::View metadata property Visible turns split view off (reflection path not built)
split.split_insets_member C turns split view off
split.view_size B views::View metadata property Bounds (size) turns split view off (reflection path not built)
tabs.tab_collection C still stops the row; zero where the build does not read it
tabs.tab_contents C still stops the row; zero where the build does not read it
toolbar.dev.colours[0][0] C turns developer colours off
toolbar.dev.colours[10][0] C turns developer colours off
toolbar.dev.colours[11][0] C turns developer colours off
toolbar.dev.colours[12][0] C turns developer colours off
toolbar.dev.colours[13][0] C turns developer colours off
toolbar.dev.colours[14][0] C turns developer colours off
toolbar.dev.colours[15][0] C turns developer colours off
toolbar.dev.colours[16][0] C turns developer colours off
toolbar.dev.colours[17][0] C turns developer colours off
toolbar.dev.colours[18][0] C turns developer colours off
toolbar.dev.colours[19][0] C turns developer colours off
toolbar.dev.colours[1][0] C turns developer colours off
toolbar.dev.colours[20][0] C turns developer colours off
toolbar.dev.colours[21][0] C turns developer colours off
toolbar.dev.colours[22][0] C turns developer colours off
toolbar.dev.colours[23][0] C turns developer colours off
toolbar.dev.colours[24][0] C turns developer colours off
toolbar.dev.colours[25][0] C turns developer colours off
toolbar.dev.colours[26][0] C turns developer colours off
toolbar.dev.colours[27][0] C turns developer colours off
toolbar.dev.colours[2][0] C turns developer colours off
toolbar.dev.colours[3][0] C turns developer colours off
toolbar.dev.colours[4][0] C turns developer colours off
toolbar.dev.colours[5][0] C turns developer colours off
toolbar.dev.colours[6][0] C turns developer colours off
toolbar.dev.colours[7][0] C turns developer colours off
toolbar.dev.colours[8][0] C turns developer colours off
toolbar.dev.colours[9][0] C turns developer colours off
toolbar.dev.console A IDC_DEV_TOOLS_CONSOLE, chrome/app/chrome_command_ids.h off the row
toolbar.dev.inspect A IDC_DEV_TOOLS_INSPECT, chrome/app/chrome_command_ids.h off the row
toolbar.get_widget_slot C still stops the row
vertical.browser_offset C turns vertical tabs off
vertical.mode_offset C turns vertical tabs off
vertical.toolbar_in_view C still stops the row; zero where the build does not read it
vertical.toolbar_leading D DIPs Rivet chooses a setting; zero where the build does not read it
vertical.update_collapse_action C turns vertical tabs off
vertical.width_offset C turns vertical tabs off
vertical.window_feature_callers C still stops the row; zero where the build does not read it
vertical.window_feature_callers[0] C still stops the row; zero where the build does not read it
vertical.window_feature_callers[1] C still stops the row; zero where the build does not read it
vertical.window_feature_tab_strip C still stops the row; zero where the build does not read it
  • Google Chrome-158.0.8127.36: 86 carried. Still stopping the row: 9 (layout.browser_window_in_view, layout.caption_container_offset, layout.frame_browser_window_offset, layout.view_bounds_offset, side_panel.contents_container, side_panel.host_view, side_panel.page_area, side_panel.toolbar, toolbar.get_widget_slot). Features off: address suggestions, app window, developer colours, frame colour, sidebar, split view, vertical tabs. Zero, not read by this build: 5.
  • Google Chrome-159.0.8154.6: 86 carried. Still stopping the row: 9 (layout.browser_window_in_view, layout.caption_container_offset, layout.frame_browser_window_offset, layout.view_bounds_offset, side_panel.contents_container, side_panel.host_view, side_panel.page_area, side_panel.toolbar, toolbar.get_widget_slot). Features off: address suggestions, app window, developer colours, frame colour, sidebar, split view, vertical tabs. Zero, not read by this build: 5.
  • Microsoft Edge-157.0.4341.46: 80 carried. Still stopping the row: 5 (layout.frame_browser_window_offset, side_panel.contents_container, side_panel.host_view, side_panel.page_area, toolbar.get_widget_slot). Features off: address suggestions, app window, developer colours, frame colour, sidebar, split view, vertical tabs. Zero, not read by this build: 6.

Not done here

  • The three rows still stop. Each still has 5 to 9 values that the window cannot do without and that have no switch: layout.view_bounds_offset, layout.frame_browser_window_offset, layout.browser_window_in_view, layout.caption_container_offset, side_panel.host_view, page_area, contents_container, toolbar, and toolbar.get_widget_slot. Most are B (see the table), but their reflection paths are not built yet. Those paths need runtime work and a browser run per browser, which this worktree may not do. Next step: find these layout fields by the ui::metadata class name of the view each one points to, the same way reflect.rs finds BrowserView.
  • On the PDB path (port), read_carried does not run, because no prior module is fetched. So a milestone change turns off every feature in the table. On the no-PDB path (find), values read from the instructions keep their features on. Fetching the prior module on the PDB path would keep more features on.
  • Owner decision: whether a row with several features switched off may be published automatically. NFR-6 says to turn those features off for that build. The gate now allows it, and the job summary and issue name each feature that is off. If the owner wants a person to see such rows first, the gate should keep returning a review for them.
  • Edge 157 writes 0x0 for vertical.update_collapse_action where other rows write the absent marker. So that address shows up as a carried number. It is in vertical tabs, which is off on Edge anyway.

🤖 Generated with Claude Code

IDC_DEV_TOOLS_INSPECT and IDC_DEV_TOOLS_CONSOLE are read from
chrome/app/chrome_command_ids.h at each milestone's branch (150 to 159),
so they are no longer row values. The runtime takes them by the build's
milestone, and the row generator writes them from the same table for older
runtimes instead of carrying them over unchecked.
A row that crosses a milestone no longer goes to review as a whole for its
carried values. Each carried value that only one feature reads (split view,
vertical tabs, the Sidebar, the app window, address suggestions, the
developer colours, the frame colour) turns that feature off with the switch
the runtime already obeys, and is cleared, so no value of the prior build
reaches a browser. A value the runtime does not read in this row is written
as zero. A value of the frame or the page area layout still stops the row.

The row names its switched-off features, and the feature gate does not
require their checks, so the rest of the row ships once its checks pass.
ui/views/view.h declares parent_, then children_, and bounds_ 0x30 bytes
after parent_. Every row that recorded the two fields by hand agrees, and
the view walk in reflect.rs finds the same pair at run time. The runtime
now takes them from the layout's bounds offset, and the row generator
writes them from it instead of carrying them over.
Both are DIPs Rivet chooses for its own layout, not values of the build, so
a row keeps them from its prior row as settings instead of listing them as
carried.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant