feat(standings): swiss legacy wrapper first iteration - #8074
Open
Rathoz wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated tiebreaker parsing can introduce duplicate manual tiebreakers when callers already include it, which should be de-duplicated to keep tie resolution consistent.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds an initial “legacy Swiss standings” wrapper module to bridge older template-style inputs into the newer Module:Standings/Table pipeline, and adjusts default tiebreaker behavior in wiki parsing.
Changes:
- Introduces
Standings/Table/Legacy/Swiss.luato build rounds/opponents/tiebreakers from legacy args and import match2 IDs by round. - Updates
Standings/Parse/Wiki.parseTiebreakersto always append the manual tiebreaker.
File summaries
| File | Description |
|---|---|
| lua/wikis/commons/Standings/Table/Legacy/Swiss.lua | New legacy Swiss wrapper that converts legacy parameters into Standings/Table.fromTemplate input and optionally maps match2 rounds via LPDB. |
| lua/wikis/commons/Standings/Parse/Wiki.lua | Changes tiebreaker defaulting by always appending the manual tiebreaker. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| -- Legacy, so let's assume finished | ||
| started = true, | ||
| finished = true, | ||
| matches = table.concat(Array.map(matches or {}, function(match) return match.id end), ','), |
Collaborator
There was a problem hiding this comment.
nitpick: Operator.property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First iteration of Swiss Legacy Adapter. Supports the local implementation on League of Legends. Probably supports a bunch more too. Additional support will be added as needed.
How did you test this change?
dev on https://liquipedia.net/leagueoflegends/Ireland_Collegiate/2023-24/Spring/Swiss_Stage