feat: fail cleaner in bracket building on error - #8073
Open
Rathoz wants to merge 1 commit into
Open
Conversation
hjpalpha
approved these changes
Sep 9, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized and improve robustness by preventing known nil/empty-field failure modes without altering the normal successful processing path.
Pull request overview
This PR improves error resilience when building match-group brackets by ensuring bracket processing can continue even if individual match processing fails, and by making bracket ID rewriting tolerant of empty match-id fields from the commons bracket template.
Changes:
- Provide a minimal fallback match object when
_processMatchfails underLogic.wrapTryOrLog, preventing bracket building from crashing. - Make
replaceBracketIdreturnnilfor empty match IDs and simplify callers to rely on that behavior (avoiding errors when fields are'').
File summaries
| File | Description |
|---|---|
| lua/wikis/commons/MatchGroup/Input.lua | Adds safer fallback behavior during bracket reading and makes bracket-id rewriting robust to empty match-id fields. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mbergen
approved these changes
Sep 9, 2026
ElectricalBoy
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?