Repository navigation
sync: untracking forgets served states; the served-manifest proof repairs the shared-files record - #70
Merged
Conversation
Served states (served.go) are kept in memory per game and peer and were not cleared on untrack, unlike everything else the game agreed with its peers (store.ForgetGameSyncState). A game tracked again within the hour could then bank a state served before the untrack as agreed. Both untrack paths, by hand and from a peer, now clear them too. (Asked for on Liquid-co#66.) Test: TestForgetServed_ForgetsOnlyThatGame. Co-Authored-By: Claude Opus 5.5 <[email protected]>
When a peer is found holding a state this device served it (served.go), the base is banked as agreed, but the record of which files both hold was left as it was, as the push proof did before Liquid-co#65. A file the peer took from what was served and this device deleted before its watcher noted it then read as one the peer had and this device never did, and was fetched back. The served proof now records the served state's files as shared too, except while the game is held as emptied (as in Liquid-co#65). (Asked for on Liquid-co#66.) This needs the previous commit: with served records surviving an untrack, the repair banked a re-tracked game's files as shared and deleted the peer's copies (TestUntrack_LateLineageWriteMustNotSurviveIntoARetrack and TestUntrackThenRetrack_DoesNotInheritStaleLineage fail 3/3 without it). Test: TestDeletion_SurvivesALostReportWhenServed (fails 3/3 without this: the deleted file comes back on both devices). Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
@ChakraFusion is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
ChakraFusion
pushed a commit
to ChakraFusion/OpenSave
that referenced
this pull request
Oct 16, 2026
Entries for Liquid-co#49, Liquid-co#70, Liquid-co#69, Liquid-co#72, Liquid-co#68 and Liquid-co#47, added at the end of the Fixed list so they do not touch Liquid-co#75's own entry. Liquid-co#57 is test-only. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As agreed on #66, in two commits:
served.go) are kept in memory per game and peer, and weren't cleared on untrack like the rest of what a game agreed with its peers (store.ForgetGameSyncState). A game tracked again within the hour could bank a state served before the untrack. Both untrack paths, by hand and from a peer, now clear them. Test:TestForgetServed_ForgetsOnlyThatGame.TestDeletion_SurvivesALostReportWhenServedfails 3/3 without this commit (the deleted file comes back on both devices).The order matters. With the repair but without the first commit,
TestUntrack_LateLineageWriteMustNotSurviveIntoARetrackandTestUntrackThenRetrack_DoesNotInheritStaleLineagefail 3/3 (the peer's files are deleted after a re-track), which is what stopped this repair in the long test run. With both commits they pass.CI on my fork is green.
🤖 Generated with Claude Code