Repository navigation
e2e: every failing test prints its daemons' logs - #57
ChakraFusion wants to merge 1 commit into
Conversation
A timing failure in CI arrives as one line ("offers = []", "daemon never
became ready") with nothing to say what the daemons did, and it rarely
happens twice: the cloud-offer failure on Windows CI took 150 runs to see
again. Only 12 tests printed the logs (logOnFailure), by asking for it.
- testutil.NewTestDaemon prints the daemon's log when its test fails, after
the daemon has stopped, so its shutdown is in it too. logOnFailure and its
calls go, since every test now has it.
- The CLI harness prints the daemon process's opensave.log before its home
is removed, and a daemon that never became ready says whether its address
was published and what the last `daemon status` answered.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
@ChakraFusion is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The failing job is
The fix for 1 (the trigger) is #58: a watch stopped during its snapshot keeps the snapshot but starts nothing, and a change reported for a game with auto-sync off doesn't start a sync. 2 is a question for you rather than a fix I'd just send: in the fallback, a side whose newest file is within the tolerance of the last sync could count as changed. That raises a conflict when it can't tell, instead of picking a side, at the risk of a prompt right after a sync. Save versions for locations would replace that fallback altogether. Would you like either? |
A timing failure in CI arrives as one line ("offers = []", "daemon never became ready") with nothing to say what the daemons did, and it rarely happens twice: the cloud-offer failure behind #56 took 150 runs on Windows runners to see again. Until now only 12 tests printed their daemons' logs (
logOnFailure), each by asking for it.testutil.NewTestDaemonprints the daemon's log whenever its test fails, after the daemon has stopped, so its shutdown is in it too.logOnFailureand its calls are removed, since every test now has it.opensave.logbefore the test's home folder is removed. A daemon that never became ready now also says whether it published its address and what the lastdaemon statusanswered (the failure seen on sync: a peer that pulled says what it now holds, so the base is recorded at once #51).Tests only; no product code changes. Checked with a deliberately failing test of each kind.
🤖 Generated with Claude Code