Feat/v058 reinterpret cmpmode backfill - #15
Open
ziyang-cheng wants to merge 4 commits into
Open
Conversation
Add CompactMode enum (layout.hpp) and forward-declare Compact, LogicalTileBytes, TilesizeCode, IsValidActiveSize on the Tile class so the incoming reinterpret_tile view (PR 376b27a) can forward SourceTile::* without pulling in the full v0.58 header-alignment commit. LogicalTileBytes equals the existing kBytes formula; Compact is fixed at Null (no compact tiles on this baseline). Members are inert outside the reinterpret view: downstream ops read tile_type_traits<TileDType>::IsValidActiveSize.
Cherry-picked onto abe8411 (headers zero-conflict; only test/tileop_api/compile.all needed a trivial union merge). (cherry picked from commit 4e977ad) Co-Authored-By: Claude Opus 4 <[email protected]>
(cherry picked from commit 376b27a)
TCVT_T was the only TEPL elementwise op that did not emit the lb2 (physical column width) shape descriptor, unlike TABS/TEXP/TRECIP/ TADDS/TMULS/TANDS/TMAX/TROWMAX. For a boxed valid-col-1 tile whose last producer is TCVT, the emulator falls back to physicalCol=validCol (Block.cpp), collapsing col to 1; a subsequent TSTORE declaring tile::Cols then fails IsCompatibleDataTile (col 1 != Cols). Append `B.DIM zero, %c7, ->lb2` with input `"i"(tile_shape_out::Cols)` to align TCVT_T with the other elementwise ops. Co-Authored-By: Claude Opus 4 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.