Reduce optimize worker memory by excluding full input list from recipe serialization - #890
Open
senarvi wants to merge 1 commit into
Open
Reduce optimize worker memory by excluding full input list from recipe serialization#890senarvi wants to merge 1 commit into
senarvi wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=====================================
Coverage 82% 82%
=====================================
Files 65 65
Lines 13377 13381 +4
=====================================
+ Hits 10949 10953 +4
Misses 2428 2428 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
I would have opened an issue, but it's restricted, so I'll describe the issue here and propose a simple solution.
I run out of memory when trying to optimize the huge OpenImages dataset. A lot of memory is wasted, copying the input list to every worker. Under spawn multiprocessing, the optimize recipe is being pickled and sent to every worker process. Currently it contains the full inputs list, so memory is scaled with the number of workers. This change fixes that by customizing recipe serialization so that worker processes no longer receive that list.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃