fix: avoid existing chunk duplication in multi-node optimize(mode="ap… - #867
Open
hillhack wants to merge 1 commit into
Open
fix: avoid existing chunk duplication in multi-node optimize(mode="ap…#867hillhack wants to merge 1 commit into
hillhack wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #865
Fixes duplicate existing chunks when
optimize(..., mode="append")is used with multiple nodes.Previously, each node included the existing dataset chunks in its intermediate index. During the final merge, these chunks were combined multiple times, resulting in duplication.
Changes
DataProcessor._done(): Excludesexisting_indexfrom intermediate node-level merges when using multiple nodes, while preserving the existing behavior for single-node append.DataProcessor._upload_index(): Addsexisting_indexonly once during the final global merge.test_multinode_done_append_no_duplicationto verify that existing chunks appear exactly once in the final index.Expected result
For an existing dataset
[A, B]and new chunks[C, D]produced by two nodes: