Remove F405 from Ruff ignore list - #2828
Open
arubittu wants to merge 1 commit into
Open
Conversation
Author
|
The pre-commit.ci failure comes from the |
Author
|
I checked the failed CI logs:
These failures appear to come from CI images or dependency changes rather than this Ruff cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
F405from Ruff’s global ignore list by importing the names used inthunder.core.utilsexplicitly. The intentional wildcard imports stay in place so the module namespace does not change. The metadata wildcard import is replaced with explicit re-exports.Addresses part of #2218.
Testing:
ruff check . --select F405ruff check thunder/core/utils.py thunder/__init__.pypytest thunder/tests/test_core.py -q(161 passed)