Implement setitem without copy_ - #2792
Draft
shino16 wants to merge 16 commits into
Draft
Conversation
shino16
marked this pull request as draft
December 10, 2025 06:53
shino16
force-pushed
the
setitem-without-copy
branch
from
December 10, 2025 07:38
aaaaf67 to
3d9be2f
Compare
Collaborator
|
The failures in CI seems relevant |
shino16
marked this pull request as ready for review
December 10, 2025 16:49
shino16
force-pushed
the
setitem-without-copy
branch
from
December 10, 2025 22:16
ad552de to
7011cc2
Compare
shino16
marked this pull request as draft
December 11, 2025 11:21
shino16
commented
Dec 11, 2025
| return VJPDual(primal, residuals) | ||
|
|
||
|
|
||
| @register_augmented_forward(prims.PrimIDs.SETITEM) |
Collaborator
Author
There was a problem hiding this comment.
We have to define forward and backward separately. If not, when we extract the forward trace from the combined fw&bw function, we hit into prims.setitem(clone(g), index, 0) in backward, which survives through DCE because setitem is tagged as DONT_DCE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2790. Previously,
inp[idx] = valuewas translated into_copy_(inp, clang.copy_with_setitem(inp, idx, val)), wherecopy_with_setitemwas an opaque primitive that only torchex could execute. This PR makes the entiresetitemopaque.Demo