fix(i18n): complete and correct the Russian translation - #1727
Open
LoranRendel wants to merge 1 commit into
Open
LoranRendel wants to merge 1 commit into
LoranRendel wants to merge 1 commit into
Conversation
ru_ru.php declared 756 of the 985 keys in en_us.php. The other 233 fell back to English silently, because ru_ru extends en_gb and calls parent::_LoadStrings(). This adds all 233, each inserted at the position the key holds in en_us.php. Eight more keys were declared but had been left at their English value, so they never fell back and never got translated either: About, Logo, CssFile, SQLStatement, QuotaEnforcement, OriginalEndDate, ResourceBufferTimeCsv, ResourceMaxNoticeCsv. It also fixes 102 existing strings that carried English Title Case into Russian, where only the first word is capitalised: "Активация Аккаунта" -> "Активация аккаунта". Some of those were wrong beyond case and are reworded from the English source: AwaitingActivation said "awaiting approval", not activation BlackoutUpdated read "прошедшее Обновлен", not a sentence ReservableTimeSlots said "reserved", not "reservable" MyReservation was plural, but the key is singular ManageResourceStatus was singular, but the key is plural DeleteUserWarning was ungrammatical ThisWeek "Этой Неделя" - wrong case ending AddQuota, CreatingReservation, MySavedReports - typos Terminology follows the existing file: Resource is "помещение", Reservation is "бронирование", Accessory is "оборудование". Five strings stay English on purpose: Email and OK read naturally in Russian, "AM / PM" is a time notation, and Client ID and Secret are PayPal API field names. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several strings remain untranslated or produce grammatically incorrect Russian output.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Completes and improves Russian localization coverage.
Changes:
- Adds missing Russian translations.
- Corrects capitalization, grammar, terminology, and untranslated values.
- Adds localized errors, page titles, and email subjects.
| File | Description |
|---|---|
lang/ru_ru.php |
Expands and corrects Russian translations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
965
to
966
| $strings['ImportICS'] = 'Импорт ICS File'; | ||
| $strings['ImportQuartzy'] = 'Импорт Quartzy File'; |
| $strings['UponRegistration'] = 'При регистрации'; | ||
| $strings['ViewTerms'] = 'Посмотреть условия использования'; | ||
| $strings['IAccept'] = 'Я принимаю'; | ||
| $strings['TheTermsOfService'] = 'условиями использования'; |
Comment on lines
+729
to
+731
| $strings['Standard'] = 'Стандартная'; | ||
| $strings['Wide'] = 'Широкая'; | ||
| $strings['Tall'] = 'Высокая'; |
| $strings['ResourceStatusChangedSubject'] = 'Доступность %s изменилась'; | ||
|
|
||
| $strings['UserDeleted'] = 'Аккаунт Пользователя %s был удален %s'; | ||
| $strings['UserDeleted'] = 'Аккаунт пользователя %s был удалён %s'; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
lang/ru_ru.phpdeclared 756 of the 985 string keys inen_us.php. The remaining 233 silently fell back to English, becauseru_ru extends en_gband callsparent::_LoadStrings()— so a Russian user just sees English text, with no error anywhere. This adds all 233, each inserted at the position the key holds inen_us.phpto keep the two files aligned and the diff reviewable.Eight more keys were declared but had been left at their English value, so they never fell back and never got translated:
About,Logo,CssFile,SQLStatement,QuotaEnforcement,OriginalEndDate,ResourceBufferTimeCsv,ResourceMaxNoticeCsv.It also corrects 102 existing strings that carried English Title Case into Russian. Russian capitalises only the first word of a phrase, so
Активация Аккаунтаshould beАктивация аккаунта.Strings reworded beyond capitalisation
A few of those 102 were wrong on the merits, not just in case. These are retranslated from the English source:
AwaitingActivationBlackoutUpdatedReservableTimeSlotsMyReservationManageResourceStatusDeleteUserWarningThisWeekAddQuota,CreatingReservation,MySavedReportsConventions followed
Terminology matches what the file already uses: Resource → «помещение», Reservation → «бронирование», Accessory → «оборудование».
Five strings stay English deliberately:
EmailandOKread naturally in Russian,AM / PMis a time notation, andClient ID/Secretare PayPal API field names.Verification
Loaded the classes and compared against
en_usdirectly:en_usbut absent fromru_ru: 233 → 0php -l lang/ru_ru.phpcleanNo behaviour change outside this one file. Also running in production on a Russian-language 5.3.0 install.