[THPubs]

Summary

Kriyon now builds, installs and runs on Windows 10/11. It was tested by hand on a real Windows 11 machine: the NSIS installer, the first-run screen, sessions (start, resume, close, crash recovery), live status and usage, the tray, notifications, the Files view (browse, edit, save, AI changes), the activity log, the structured view, the command palette and the app tour. Reinstalling over a running session also worked, and the session survived.

The design is recorded in docs/adr/0055-windows-support.md. In short:

• Same daemon and protocol. The session socket stays a Unix-domain socket; Windows gets it from uds_windows behind kriyon_core::uds.
• A Job Object is the Windows tree stop. The shell runs in a kill-on-close job, so a stop, a crash or the app's reaper ends the whole tree. The job also gives the busy signal.
• ConPTY's opening cursor query is answered by the daemon, because nothing is attached when the shell starts.
• PowerShell is the session shell. Claude launch lines are written in PowerShell syntax.
• Daemons run from a per-build copy in the run dir, so an update can replace kriyon-ptyd.exe while sessions are open.
• The process table comes from a Toolhelp snapshot plus each process's command line, shaped like ps rows.
• Paths: canonicalize goes through dunce (clippy now bans the std one), repo-relative paths use /, and the frontend reads C:\ paths.
• No menu bar on Windows. The tray icon is in colour, shortcut labels say Ctrl, and the copy says "this PC" and "File Explorer" there.
• Helper programs (git, installs, setup commands) start without console windows.

Fixes that also matter on macOS:

• Companion files are only written when they change, so an app launch no longer reloads the plugin ("plugin.json changed") in every live session.
• A file save closes the target before the atomic rename.

Known gaps

• Status hooks need Python on Windows. Kriyon uses a real python.exe when there is one. With none, it leaves the hook entries out instead of failing on every event; the companion still loads. Rewriting the hook scripts as a small Rust program would remove the dependency.
• Releases are Mac-only. There's no Windows signing or update feed yet, and a few repo tooling tests (the release script, a Claude hook filter) fail when run on Windows.

Test plan

• pnpm check on macOS (run by the commit and push hooks)
• On Windows: clippy clean; 702 core, 13 daemon, 398 app and 2,607 frontend tests pass
• Hand-tested on Windows 11 with the installed release build

Checklist

• The PR targets dev.
• I wrote or updated tests, and pnpm check passes.
• I read and tested every line, and I can explain it in review.
• AI tools wrote most of this change. (Tick if true. See Using AI tools.)

🤖 Generated with Claude Code

[THPubs]

Review and fix — pass 1

Full review of the pull request at 7530809, then fixes and a re-check of them, through 0335b4b.

Fixed 25 issues in 2 passes. All checks green on macOS and on a Windows 11 machine.

• Pushed as 8 fix commits, plus a merge of dev (one import conflict).
• The template checklist was added to the description.

Notes

• A macOS CI run failed once on a timing test in watcher.rs that this pull request does not touch; it passed on rerun.

Fixed this pass

• src-tauri/src/entry_cmd.rs:248 — Stop silent permanent delete when Recycle Bin is unavailable
• src-tauri/src/daemon_rt.rs:208 — Don't TerminateProcess Toolhelp descendants on Windows
• src/terminal/launchCommand.ts:47 — Read the seed prompt as UTF-8 in Windows PowerShell
• crates/kriyon-core/src/proc.rs:1056 — Replace the real Windows profile path with a placeholder
• crates/kriyon-core/src/private_fs.rs:31 — Use a real file id, not creation time, as Windows identity
• src/terminal/launchCommand.ts:41 — Scope nested-session env to the one claude launch
• src-tauri/src/integration.rs:131 — Tell the user when status hooks are left out for lack of Python
• crates/kriyon-ptyd/src/pty.rs:288 — One Windows busy rule; don't count orphans in the job
• src-tauri/src/hooks.rs:76 — Quote hook paths safely for apostrophes in Windows profiles
• src-tauri/src/sandbox.rs:122 — Handle verbatim paths dunce keeps for long Windows paths
• src-tauri/src/sandbox.rs:449 — Refuse Windows-only unsafe leaf names
• crates/kriyon-core/src/proc.rs:508 — Recognise npm-installed claude on Windows
• src-tauri/src/tray.rs:160 — Don't show Ctrl+N / Ctrl+Q in the Windows tray menu
• crates/kriyon-core/src/activity_log.rs:214 — Teach reaches_outside Windows paths too
• src/terminal/sessionHost.ts:422 — Take the launch-line shell from Rust, not userAgent
• src-tauri/src/bootstrap_cmd.rs:127 — Use shellinit::WINDOWS_SHELL for setup commands
• src/state/paths.ts:27 — One Windows-path rule for the frontend
• src-tauri/src/sleep_rt.rs:76 — Add a gated Windows terminate beside signal_gated
• src-tauri/src/links_cmd.rs:202 — One find-on-PATH helper for Windows
• src-tauri/src/links_cmd.rs:197 — Use spawn::no_console instead of redefining the flag
• src/terminal/launchCommand.test.ts:49 — Assert the PowerShell native-arg escaping
• src/platform/os.ts:24 — Test the platform detection the launch line depends on
• src/platform/shortcut.ts:17 — Don't strip the Help mention by matching exact copy
• src-tauri/src/handoff_rt.rs:139 — Move note_hook_event's doc back above it
• src-tauri/src/commands.rs:29 — Move ptyd_binary's doc back above the function

Checked by 5 finders (processes, correctness, boundary, contract, tests, frontend, public text, docs, left behind, step 5 re-check of the fixes) · architecture review · scorer: 55 scored, 25 kept.

---

Ready to merge, as far as this review can see. Nothing is open from this pass or any pass before it.