Repository navigation
Build InfiniMap as SDK-style projects on .NET 10 - #19
Merged
Merged
Conversation
Converts InfiniMap and InfiniMap.Test to SDK-style projects targeting net10.0 (CSHARP7 define, language version 7.3 and the checked-in AssemblyInfo kept), moves the tests to NUnit 3.14 with the NUnit 3 adapter so they run under dotnet test, and replaces the Travis/xbuild build with GitHub Actions. The separate InfiniMap-Net8 project, which linked the same sources, is superseded by the converted InfiniMap project and removed. The solution is regenerated with Any CPU configurations; its x86 mappings stopped the test host from discovering tests. Part of LambdaSix/OctoGhast#101, which consumes InfiniMap as a submodule. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_015F1qm2fxgPvF4TFvmepp9p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Nicola · project thread
Before: InfiniMap and its tests were legacy .NET Framework 4.6.2 projects built by Travis with
xbuild. A separateInfiniMap-Net8project linked the same sources for .NET 8.After:
InfiniMapandInfiniMap.Testare SDK-stylenet10.0projects.dotnet buildanddotnet testwork on any OS, and the 39 tests run green. A GitHub Actions workflow replaces Travis, andInfiniMap-Net8is removed because the main project now covers it.This lets OctoGhast (LambdaSix/OctoGhast#101) reference the submodule's own project instead of a wrapper.
How: the
CSHARP7define, language version 7.3 and the checked-inAssemblyInfo.csfiles are kept. Determinism is off becauseAssemblyInfouses a wildcard version. Tests move to NUnit 3.14 with the NUnit 3 adapter. I regenerated the solution with Any CPU configurations because its x86 mappings stopped the test host from discovering any tests.InfiniMap.nuspecis left in place, untouched.🤖 Generated with Claude Code
https://claude.ai/code/session_015F1qm2fxgPvF4TFvmepp9p
Generated by Claude Code