docs(lending_pool): add #1089 references to donation-attack fix comments - #1699
Open
Aj-Kayvee wants to merge 10 commits into
Open
docs(lending_pool): add #1089 references to donation-attack fix comments#1699Aj-Kayvee wants to merge 10 commits into
Aj-Kayvee wants to merge 10 commits into
Conversation
…fix comments Link issue LabsCrypt#1089 (first-depositor share inflation / donation attack) to the existing code and test documentation so future readers can trace the fix back to the original report. - TotalManagedAssets doc: add (LabsCrypt#1089) to donation-immunity note - VIRTUAL_SHARES/VIRTUAL_ASSETS doc: add (LabsCrypt#1089) to attack description - total_managed_assets() doc: add LabsCrypt#1089 alongside LabsCrypt#1380 - calc_shares_to_mint() doc: add LabsCrypt#1089 alongside LabsCrypt#1380 - test module header: add LabsCrypt#1089 to the slippage/donation test section No logic changes — documentation only. Closes LabsCrypt#1089 🤖 Generated with Codebuff Co-Authored-By: Codebuff <[email protected]>
The contracts 'rust-toolchain.toml' pins Rust 1.85.0 for soroban-sdk 22 compatibility, but the CI workflows used dtolnay/rust-toolchain@stable which overrides the pin with the latest stable Rust. The newest stable is incompatible with soroban-sdk 22, causing cargo clippy to panic with exit code 101. Switch to @master so the action respects the repository's rust-toolchain.toml.
dtolnay/rust-toolchain with an explicit toolchain installs only that toolchain without the extra components declared in rust-toolchain.toml. The contracts Clippy step then runs without a clippy component installed, causing cargo clippy to panic with exit 101. Add the rustfmt and clippy components matched to the repository's rust-toolchain.toml.
…s/1089-refer-donation-attack-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issue #1089 (first-depositor share inflation / donation attack) to the existing code and test documentation so future readers can trace the fix back to the original report.
No logic changes — documentation only.
Closes #1089
🤖 Generated with Codebuff
Pull Request Checklist
Please ensure your PR follows these steps, mirroring our
CONTRIBUTING.mdguidelines.CONTRIBUTING.mddocument.