Fix misleading LoanError variants in loan_manager - #1688
Conversation
LoanManager returned misleading error variants, making the error API ambiguous for integrators and indexers. Swap to the correct, already-defined variants on each path and wire the dead InvalidExtension variant to a real path. closes LabsCrypt#1060
…ger-returns-misleading-error-variants;-InsufficientCollateral/NoProposedAdmin/MaxExtensionsReach
LoanManager returned misleading error variants, making the error API ambiguous for integrators and indexers. Swap to the correct, already-defined variants on each path and wire the dead InvalidExtension variant to a real path. closes LabsCrypt#1060
…ror-variants;-InsufficientCollateral/NoProposedAdmin/MaxExtensionsReach
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }, | ||
| }); | ||
|
|
||
| const critical = violations.filter( |
Comment on lines
+16
to
+18
| const critical = violations.filter( | ||
| (v) => v.impact === "critical" || v.impact === "serious", | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoanManager returned misleading error variants, making the error API ambiguous for integrators and indexers. Swap to the correct, already-defined variants on each path and wire the dead InvalidExtension variant to a real path.
closes #1060
Pull Request Checklist
Please ensure your PR follows these steps, mirroring our
CONTRIBUTING.mdguidelines.CONTRIBUTING.mddocument.