fix: correct Stellar address regex and add regression coverage - #1637
Open
Henrichy wants to merge 10 commits into
Open
fix: correct Stellar address regex and add regression coverage#1637Henrichy wants to merge 10 commits into
Henrichy wants to merge 10 commits into
Conversation
Author
|
@ogazboiz please review this PR. Thank you |
Author
|
@K1NGD4VID please review |
grid merged
The loan_manager contract was referencing an undefined variable late_fee_numerator when calculating the incremental late fee. This calculation must compute the numerator from the remaining principal, late fee rate, and overdue ledgers before passing to money::round_div. Fixes compilation error E0425 and resolves CI failures in contracts, backend, and CodeQL analysis.
Regenerated lock files to ensure npm ci works correctly in CI. Removes mismatched dependencies (@emnapi packages) that were causing npm ci to fail with 'Missing: @emnapi/core and @emnapi/runtime' errors.
The lock files had corrupted entries (@emnapi, json-schema-traverse) causing npm ci to fail. Regenerated all three lock files by deleting and running npm install to ensure they're properly in sync with their respective package.json files. This fixes the npm EUSAGE error 'can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1011