Repository navigation
Correct sampler conditionals, posterior scores and detector edge cases - #3
Draft
ZacharyHendrix wants to merge 1 commit into
Draft
ZacharyHendrix wants to merge 1 commit into
ZacharyHendrix wants to merge 1 commit into
Conversation
Preserve calibrated background and accepted-position caches, correct endpoint motion-buffer reuse and likelihood-only annealing, and repair stored scores and finite sample selection. Stabilize SPAD likelihoods and inactive-emitter handling. Validation: 511 CPU assertions pass with Pkg.test(); nine joint-posterior moments agree with independent quadrature within 1.11 batch MCSE. GPU numerical validation remains blocked by a CUDA compilation failure reproduced without SP2T. Association and unknown-count convergence require separate validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes inconsistent sampler conditionals and incorrect saved posterior scores.
Validation on Windows x64 with Julia 1.12.6:
Pkg.test()passed all 511 assertions, including 506 new regressions covering Float32/Float64, SPAD/EMCCD, activity masks, and zero-emitter cases.An independent one-frame, one-emitter SPAD reference check jointly varied position and brightness. Three chains retained 80,000 draws each; all nine checked moments agreed with numerical integration within 1.109 batch Monte Carlo standard errors. Quadrature refinement and domain-extension checks passed.
GPU validation remains blocked: CUDA.jl compilation fails on a basic broadcast independently of SP2T. Extension loading succeeds, but numerical GPU validation is outstanding. Julia 1.11 and other platforms also need CI.
This draft covers core correctness; reconnection, unknown-count mixing, and broader scientific performance remain separate validation work.