Improve dirty state handling - #2044
Open
labkey-nicka wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This improves our dirty state handling to catch a couple of cases we are missing:
SelectInputin aFormsyform are not being recorded as a dirty state change.useRouteLeaveoverridebeforeunloadhandling allowing the user to navigate away from dirty page (e.g., from a modal) and not receive an alert.Related Pull Requests
Changes
In
useRouteLeave:usePromptandbeforeunloadnow block on the aggregate, so React Router's single-blocker limit no longer masks consumersbeforeunloadlistener replaces one per consumerIn
Formsy:isChanged()now uses each input's mount-timepristineValue, not the live value prop a controlled parent overwritesresetModel()applies explicit values viaresetValue(), making them the new baseline so a reset isn't reported dirtywithFormsyskips re-applying a value the input already holds, dropping a redundant validation and duplicateonChange