Skip to content

release: check that latest*.yml points at files that were actually uploaded #355

Open

Description

@BernardJen

What

#86 found that latest-mac.yml named files that did not exist on the release, so every macOS auto-update 404'd for three releases. The fix was explicit artifactNames. The guard proposed there -- check that every url/path in the update metadata exists among the uploaded assets -- was never added: the publish job uploads latest.yml and latest-mac.yml unchecked (.github/workflows/release.yml, files: of the Create Release step).

Any future change to productName or the artifact names can silently break updates the same way.

Fix

A step before Create Release that parses both yml files and fails if any url or path is not among ./artifacts/**.


Found while reconstructing the Electron app's decisions as ADRs for the egui port (#346, docs/adr/open-questions.md). Line numbers are from main at 787375b (v3.4.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions