Repository navigation
Add latest Python/JAX/NumPy CI job; bump version to 0.1.1 - #52
Merged
Merged
Conversation
Add a `latest` job to the Tests workflow that runs on the newest stable Python with the newest JAX and NumPy, ignoring the pins in requirements.txt. Fix the three failures it surfaced: - VariableGroup.add_check read `self.__annotations__`, which instances no longer inherit on Python 3.14 (PEP 649/749); check dataclass fields. - Variable.__getitem__ doctest printed np.True_ under NumPy 2; use np.array_equal, which returns a Python bool. - test_custom_implicit assigned a shape-(1,) array to a scalar element, which NumPy 2.5 rejects; reduce it with np.sum like the second test op. Bump the version to 0.1.1 in csdl_alpha/__init__.py and the Conda recipe, which was still at 0.0.0a2.
msperryucsd
self-requested a review
October 9, 2026 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latestjob to the Tests workflow. It runs on the newest stable Python thatactions/setup-pythonoffers (3.xwithcheck-latest) and installs the newest JAX and NumPy, ignoring the pins inrequirements.txt. The job prints the versions it resolved.VariableGroup.add_checkreadself.__annotations__. On Python 3.14 (PEP 649/749), instances no longer inherit class annotations, so this raisedAttributeError. It now checks the dataclass field names, which also covers fields inherited from a parent group.Variable.__getitem__doctest: under NumPy 2,np.all(...)displays asnp.True_. The example now usesnp.array_equal, which returns a Pythonbool.test_custom_implicitassigned a shape-(1,)array to a single element, which NumPy 2.5 rejects. It now reduces withnp.sum, as the file's second custom op already does.csdl_alpha/__init__.pyand inrecipe/recipe.yaml. The recipe was still at0.0.0a2, so a tag build would have published the wrong version.Testing
Ran the full suite locally (
377 passed, 2 skipped) in two environments:Note: Python 3.15.0 was released today but is not in
setup-pythonyet, andh5pyhas no 3.15 wheels yet. When the runners pick up 3.15, this job will move to it automatically. It may then fail untilh5pypublishes wheels.