Repository navigation
Unify entity share state normalization and fix ShareLockButton colored status - #387
Conversation
- Standardize active color computation in ShareLockButton so items with either isPublic or isGuest display the vibrant accentColor and subtle background tint. - Add realtime settle event listener (kylrix:share-published) in ShareLockButton to optimistically update icon state immediately upon publish completion. - Normalize share properties across Notes, Goals, Vault Credentials, TOTPs, Events, and Forms. - Add unit tests for ShareLockButton covering unshared, public, guest, and realtime event states. Co-authored-by: nathfavour <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes the issue where share icons do not reflect the actual shared state by relaxing active color thresholds in ShareLockButton, normalizing entity sharing properties across cards and rows (including metadata JSON resolution for vault items and TOTPs, and tag/status checks for goals and forms), and listening for realtime share publish completion events.
PR created automatically by Jules for task 17303283635703164768 started by @nathfavour