Repository navigation
feat(chat): server-chosen model with automatic fallback; no model picker; charge after success - #226
Merged
Merged
Conversation
…uccess Remove the chat model picker and placeholder buttons; client no longer sends providerId/model (ignored if sent). Plan: preferred BYOK -> platform Groq -> platform Mistral; fallback on transient failures/empty reply, never on auth/bad_request/credits/limits; 52s deadline split; observer + log line. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
|
Deployment failed for project okara-alternative with the following error: Learn More: https://vercel.com/kumar2421s-projects?upgradeToPro=build-rate-limit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat no longer lets the client pick provider/model (fields ignored): the SERVER builds an ordered plan = user's preferred BYOK model (Settings) -> platform Groq default -> platform Mistral; falls back on rate_limit/server/timeout/network/model_unavailable/empty reply, NEVER on auth/bad_request/402/400/401/409/422 (policy denials incl. chat_limit stop the turn); max 3 attempts inside a 52s turn budget (first attempt <=55% of remaining; drivers take no AbortSignal so a timed-out attempt is abandoned, not cancelled). Credits: read-only affordability check before, ONE charge after a successful reply, none on failure, BYOK never charged. User never sees the backup model; one structured log line per turn (provider/model/fallback/attempts/ms, no content). Client: ModelPicker, Attach and Mention placeholders removed; Settings LLM Providers copy now says chat uses the preferred model first and falls back to our defaults. DELIBERATE behaviour changes (all in tests): 422 'no candidates' replaces 'No model selected'/501/'not connected' and runs after auth+scope; charge moved after answer; empty reply = failed attempt; observer events extended. 36 service tests; 1936 pass. Not verified live. Known: all-fail error text can name the last provider; other agent modals (CodeFix, CMS) still show 'Select a model' (out of scope).
🤖 Generated with Claude Code