fix(react): add support for virtual nodes - #73
Merged
Merged
Conversation
Collaborator
|
LGTM |
Thibault-Pelletier
marked this pull request as draft
September 11, 2026 18:14
Contributor
Author
|
@jourdain I'm switching this branch to draft (will use to move the client adapter / do further testing using trame-slicer). |
Thibault-Pelletier
force-pushed
the
fix-react-virtual-node
branch
from
September 12, 2026 08:21
01d58ef to
6070461
Compare
Add client adapter responsible for converting events and style between vue and react.
Thibault-Pelletier
force-pushed
the
fix-react-virtual-node
branch
from
September 12, 2026 08:31
6070461 to
5b9b7df
Compare
Thibault-Pelletier
marked this pull request as ready for review
September 12, 2026 08:32
Contributor
Author
|
@jourdain I have added the client adapter and kept what I tested in trame-slicer as its interface: responsible for event and style translation. I'm not sure more will be needed on trame-slicer's side, so it should be good enough on my end. |
Collaborator
|
Seems reasonable. You can merge if you want or let me know if I need to merge it on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.