Skip to content

build(deps): use @kikobeats/got instead of got - #343

Merged
Kikobeats merged 1 commit into
masterfrom
Kikobeats/use-kikobeats-got
Oct 16, 2026
Merged

Kikobeats merged 1 commit into
masterfrom
Kikobeats/use-kikobeats-got

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Replaces got@~11.8.6 with @kikobeats/got@~11.8.9, the CommonJS fork of got 11. Supersedes #342 (got 16 is ESM-only and would break every require('got') here).

Changes

  • package.json: got → @kikobeats/got
  • require('got') → require('@kikobeats/got') in src/commands/notification/{slack,telegram}.js, test/helpers.js, test/routes/index.js

Testing

npm test: lint plus 27/27 ava tests pass, including notification:slack and notification:telegram, which make real requests through got.

Closes #342

🤖 Generated with Claude Code


Note

Low Risk
Dependency rename with the same got 11 API surface; low risk if the fork stays compatible with existing .post, .extend, and JSON options usage.

Overview
Swaps the HTTP client dependency from got@~11.8.6 to @kikobeats/got@~11.8.9, a CommonJS-compatible fork of got 11, so the project can stay on require() without moving to ESM-only got 16.

All require('got') call sites are updated to require('@kikobeats/got') in Slack/Telegram notification commands and in test helpers/route tests (including the extended client with retry: 0). Runtime behavior is intended to match got 11; this is a package-name and dependency pin change, not new HTTP logic.

Reviewed by Cursor Bugbot for commit 18a87dc. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the HTTP client used for Slack and Telegram notifications and by the test suite.

got >= 12 is ESM-only. @kikobeats/got is the CommonJS fork of got 11,
so the existing require() calls and API keep working.

Supersedes #342.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tom Ready Ready Preview Oct 16, 2026 7:51am UTC

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 687566bd-00ed-4b1e-841e-b65ed484d17f
📥 Commits

Reviewing files that changed from the base of the PR and between f208a08 and 18a87dc.

📒 Files selected for processing: 5
  • package.json
  • src/commands/notification/slack.js
  • src/commands/notification/telegram.js
  • test/helpers.js
  • test/routes/index.js
+-------------------------------------------------------------+
| I'm sorry, Dave. I'm afraid I can't let you write that bug. |
+-------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kikobeats
Kikobeats merged commit 7699cf8 into master Oct 16, 2026
4 of 5 checks passed
@Kikobeats
Kikobeats deleted the Kikobeats/use-kikobeats-got branch October 16, 2026 07:53
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38869865111

Warning

No base build found for commit f208a08 on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 83.642%

Details

  • Patch coverage: 2 of 2 lines across 2 files are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 796
Covered Lines: 657
Line Coverage: 82.54%
Relevant Branches: 121
Covered Branches: 110
Branch Coverage: 90.91%
Branches in Coverage %: Yes
Coverage Strength: 7.74 hits per line

💛 - Coveralls

This branch was successfully deployed

1 active deployment
Preview — 18a87dc9 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants