Repository navigation
build(deps): use @kikobeats/got instead of got - #343
Merged
Merged
Conversation
got >= 12 is ESM-only. @kikobeats/got is the CommonJS fork of got 11, so the existing require() calls and API keep working. Supersedes #342. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 5
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 38869865111Warning No base build found for commit Coverage: 83.642%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
got@~11.8.6with@kikobeats/got@~11.8.9, the CommonJS fork of got 11. Supersedes #342 (got 16 is ESM-only and would break everyrequire('got')here).Changes
package.json:got→@kikobeats/gotrequire('got')→require('@kikobeats/got')insrc/commands/notification/{slack,telegram}.js,test/helpers.js,test/routes/index.jsTesting
npm test: lint plus 27/27 ava tests pass, includingnotification:slackandnotification:telegram, which make real requests through got.Closes #342
🤖 Generated with Claude Code
Note
Low Risk
Dependency rename with the same got 11 API surface; low risk if the fork stays compatible with existing
.post,.extend, and JSON options usage.Overview
Swaps the HTTP client dependency from
got@~11.8.6to@kikobeats/got@~11.8.9, a CommonJS-compatible fork of got 11, so the project can stay onrequire()without moving to ESM-only got 16.All
require('got')call sites are updated torequire('@kikobeats/got')in Slack/Telegram notification commands and in test helpers/route tests (including the extended client withretry: 0). Runtime behavior is intended to match got 11; this is a package-name and dependency pin change, not new HTTP logic.Reviewed by Cursor Bugbot for commit 18a87dc. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit