Skip to content

Potential fix for code scanning alert no. 16: Incomplete URL substring sanitization #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KiidxAtlas merged 1 commit into from
Apr 1, 2026
Merged

Potential fix for code scanning alert no. 16: Incomplete URL substring sanitization #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion docs-engine/src/docResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,17 @@ export class DocResolver {
private getCorpusGroupForIndexedSymbol(symbol: IndexedSymbolSummary): string | undefined {
const root = symbol.package || symbol.name.split('.')[0] || '';
const baseUrl = this.inventoryFetcher.getPackageBaseUrl(root) || this.inventoryFetcher.getPackageBaseUrl('builtins');
return baseUrl?.includes('docs.python.org') ? PYHOVER_PYTHON_STDLIB_CORPUS_GROUP : undefined;
if (!baseUrl) {
return undefined;
}

try {
const parsed = new URL(baseUrl);
return parsed.hostname === 'docs.python.org' ? PYHOVER_PYTHON_STDLIB_CORPUS_GROUP : undefined;
} catch {
// If baseUrl is not a valid URL, fall back to no special corpus group.
return undefined;
}
}

async buildPythonStdlibCorpus(
Expand Down
Loading