Skip to content

feat(v2): add Private PKI product names that set ProductFamily and ProductVariant - #54

Open
spbsoluble wants to merge 1 commit into
feat/v2-consolidatedfrom
feat/v2-private-pki-product-names
Open

spbsoluble wants to merge 1 commit into
feat/v2-consolidatedfrom
feat/v2-private-pki-product-names

Conversation

@spbsoluble

Copy link
Copy Markdown
Collaborator

Summary

The plugin advertised SSL/TLS product names only, so a Private PKI template had to pick an SSL name (for example DV SSL) and set ProductFamily=private-pki and ProductVariant by hand. This adds two Private PKI product names that set both for you.

Features

  • New products Private PKI Intranet SSL and Private PKI IGTF Host in GetProductIds(), Constants.Products and integration-manifest.json.
  • Selecting one defaults ProductFamily to private-pki and ProductVariant to intranet-ssl or igtf-host (EnrollmentParams), so the order goes to the Private PKI endpoint with no extra parameters.
  • A ProductFamily or ProductVariant that contradicts the product is rejected when the template is saved and at enrollment, before any CA call.
  • Templates that pair an SSL/TLS product with ProductFamily=private-pki keep working.

Fixes

  • Enroll() required a product code on V2 too (it threw "Template parameter 'ProfileId' is required"). The check is now V1-only, as ValidateProductInfo already was: V2 needs no code, and the new products have no V1 default code. On V1 they still need ProductCode.
  • The ProductFamily and ProductVariant template annotations no longer declare ssl / dv defaults, since the plugin derives both from the product.
  • The GetProductIds() comment no longer says a numeric ProductCode is required.

Testing

  • Unit tests: 1439 passed, 0 failed (Release).
  • New tests: Private PKI names route to the Private PKI body with the right variant; matching explicit parameters still enroll; a contradicting variant or a non-private-pki family fails fast with no CA call; save-time validation rejects ProductFamily=ssl and accepts no parameters; EnrollmentParams family/variant defaults; V1 Private PKI name without ProductCode throws.
  • Updated tests: GetProductIds count (10 → 12); the sync type-ID round-trip test covers SSL products only (Private PKI has no known catalog productTypeID).
  • Release build, DcvSupport=true and false: 0 warnings, 0 errors.

Other

  • Docs: docsource/configuration.md, README.md and the manifest descriptions for ProductCode, ProductFamily and ProductVariant; CHANGELOG entry under 2.0.0.

…oductVariant

GetProductIds() advertised SSL/TLS names only, so a Private PKI template had to pick an
SSL name (for example DV SSL) and set ProductFamily=private-pki plus ProductVariant.
Add "Private PKI Intranet SSL" and "Private PKI IGTF Host": selecting one defaults
ProductFamily to private-pki and ProductVariant to intranet-ssl / igtf-host. A
ProductFamily or ProductVariant that contradicts the product is rejected at template
save and at enrollment, before any CA call. SSL products paired with
ProductFamily=private-pki keep working.

Enroll() required a product code on V2 too; that check is now V1-only (V2 needs no code,
and the new names have no V1 default). The ProductFamily/ProductVariant annotations no
longer declare "ssl"/"dv" defaults, since the plugin derives both from the product.

Also corrects the GetProductIds() comment, which described numeric codes as required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant