Skip to content

test(live): align V2 integration tests with no product-code pre-checks - #51

Merged
spbsoluble merged 1 commit into
feat/v2-consolidatedfrom
test/v2-integration-product-code-followup
Nov 17, 2026
Merged

spbsoluble merged 1 commit into
feat/v2-consolidatedfrom
test/v2-integration-product-code-followup

Conversation

@spbsoluble

Copy link
Copy Markdown
Collaborator

Summary

PR #50 removed V2's product-code pre-checks: template save no longer looks a ProductCode up in the catalog, and enrollment no longer rejects extra SANs with the single-domain guard. Two live integration tests still expected the old behavior. This PR updates them to match.

Fixes

  • V2ApiTests.ValidateProductInfo_V2_RejectsUnknownProductCode expected V2 template save to reject an unknown code (999999) with "not found", so it now failed. It's renamed to ValidateProductInfo_V2_AcceptsUnknownProductCode_WithoutCatalogCheck and asserts that the code is accepted. V1 still rejects an unknown code when a template is saved.
  • V2ApiTests.ValidateProductInfo_V2_AcceptsConfiguredProductCode: the assertion reason no longer says the code has to be in the catalog.
  • V2FullLifecycleTests.Enroll_V2_WildcardDv_WildcardPlusApexSan_RecordsActualBehavior: a FAILED result is no longer blamed on the removed guard, and the test no longer asserts on the guard's message. It logs the result and cleans up any order that was created. Its doc comment now describes what the plugin actually does: a wildcard's bare apex isn't an extra name, so the request goes out as a single-domain wildcard order.

Testing

  • Release build: 0 warnings.
  • V2ApiTests.ValidateProductInfo_V2_*: both pass. These are read-only; no order is placed.
  • No plugin or unit-test changes.

Other

Targets feat/v2-consolidated (#39).

PR #50 removed V2's save-time ProductCode catalog check and the single-domain
SAN guard, but two live tests still described or asserted them:

- V2ApiTests.ValidateProductInfo_V2_RejectsUnknownProductCode expected an
  unknown code to be rejected at template save. Renamed to
  ValidateProductInfo_V2_AcceptsUnknownProductCode_WithoutCatalogCheck and
  now asserts it's accepted; ValidateProductInfo_V2_AcceptsConfiguredProductCode's
  reason no longer says the code must be in the catalog.
- V2FullLifecycleTests.Enroll_V2_WildcardDv_WildcardPlusApexSan_RecordsActualBehavior
  no longer attributes a FAILED result to the removed guard; it logs the
  result and cleans up any order created.
@spbsoluble
spbsoluble merged commit 6fb7eb5 into feat/v2-consolidated Nov 17, 2026
39 checks passed
@spbsoluble
spbsoluble deleted the test/v2-integration-product-code-followup branch November 17, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant