Repository navigation
tkldev-setup: clone appliance APP from keel-APP on the keel-linux organization - #3
Merged
Merged
Conversation
…anization Appliance repositories of the keel-linux organization carry the keel- prefix (decision 0006: keel-core, keel-wordpress, ...), while infrastructure repositories keep their upstream names. When the remote is the organization (GIT_REMOTE_URL with a keel-linux path component, https or ssh, any case), app_repo_name maps APP to keel-APP unless it is already prefixed; the local product directory stays products/APP so make and bt-layer keep the appliance name. Any other remote is unchanged: turnkeylinux still gets the -apps organization and a mirror is used as is. Three bats cases: the https organization remote (core from keel-core, common and buildtasks unprefixed), an ssh remote with a prefixed and an unprefixed appliance, and app_repo_name on the turnkeylinux, a mirror and an IPv6 organization mirror remote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: tkldev-setup clones appliances as /, so with GIT_REMOTE_URL pointing at the organization
tkldev-setup coreasks for keel-linux/core, which does not exist: appliances are prefixed there (decision 0006), infrastructure is not.Diagnosis: the only remote-dependent rule was the turnkeylinux one (append -apps for appliances); the organization needs a name mapping, not a different remote.
Fix: app_repo_name APP REMOTE maps APP to keel-APP when REMOTE has a keel-linux path component (https or ssh, any case) and APP is not already prefixed; the local directory stays $FAB_PATH/products/APP so make and bt-layer keep the appliance name. Every other remote behaves as before (turnkeylinux gets -apps, a mirror is used unchanged). Usage text updated.
Tests: 66 bats (3 new: the https organization remote with core becoming keel-core and common staying common; an ssh remote with wordpress and keel-lamp; app_repo_name on turnkeylinux-apps, an IPv6 mirror and an IPv6 organization mirror). tests/coverage.sh under kcov: tkldev-setup 99.48 percent (190 of 191 lines), above the 99 threshold of pull request #2.
Serves BRIEF section 10 and org-plan section 4 (naming rule of decision 0006).