Repository navigation
docs: 0049, precision of 2026-10-11: the rejoin leaves the spec alone - #57
Merged
Merged
Conversation
The role is runtime state from the first claim on (0020); what 0049 says the rejoining old primary writes into its own spec is the emitted spec. With it, the three points approved the same day for keel#93: the root CA in every cloud mode and a database leaf per node, ip_nonlocal_bind on both nodes of a pair, and the standby's dumps as the next pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text only. The maintainer's approval of 2026-10-11 on Keel-Linux/keel#93's four questions, recorded under 0049: the rejoin does not rewrite instance.yaml (the role is runtime state, 0020; 0049's "writes role: replica into its own spec" is the emitted spec), the mesh root CA in every cloud mode with a database leaf per node, ip_nonlocal_bind on both nodes of a pair, and the standby's dumps as the next PR. The README row is extended.