Repository navigation
docs: 0041 amendment, an overlay an upgrade adds to the chain - #54
Merged
Merged
Conversation
Rule 25 makes every spec invalid when an upgrade adds an overlay to the chain, as keel-core 0.1.3 did with vip. Proposed: such an overlay takes its default for the mode with a warning; one the spec declared when it was last applied and leaves out stays an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed amendment to 0041 and rule 25 of docs/manifest-v1.md, for the maintainer's approval.
keel-core 0.1.3 added
vipto Core, and afterapt full-upgradeevery keel command on two Keel Web nodes refused the spec (overlays.vip: not declared). Rule 25 as written makes any overlay added to a chain break every existing spec on upgrade.The amendment: an overlay the spec does not declare, and did not declare when it was last applied (recorded by
apply --system), takes its manifest default forinstallation.modewith a warning. One the spec declared and drops stays an error, so 0027's explicit spec holds for what the operator wrote. The spec file is never edited by keel or by a maintainer script. The note explains why the postinst option was not taken.Implemented in Keel-Linux/keel, branch
fix/overlay-new-in-chain.