Bring merged #17 and #18 into main - #19
Merged
Merged
Conversation
Serial runs on the same two-slot server passed 3/4. The one failure had the same Name-field error as the concurrent runs, so concurrency does not cause it. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
64K loads on the RTX 3070 Ti with ~870 MiB VRAM spare and handles a 60K-token prompt. The live image task passed 3/4 once old page views were pruned; headless Chrome needed a normal user agent. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
… timeout Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
…ntext Final review fixes: robust timing tests, host/user masked in logs, step timeouts and a repetitions cap so restore fits the job, phase-2 failures keep phase-1 results, per-suite ctx on the VRAM chart, GPU name variable, docs corrected. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
With PW_MCP_OUTPUT_MAX_SIZE=0 the launcher expanded an empty array under
set -u. bash before 4.4 (macOS /bin/bash 3.2, used by the macOS CI runner)
treats that as unbound and exits 1. Use the ${a[@]+"${a[@]}"} form and
add a test that runs the launcher under the old system bash.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq
Add manual RTX benchmark action with Pages dashboard
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (78)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
PRs #16, #17 and #18 were stacked. They were merged within seconds of each other, so GitHub had not yet moved #17 and #18 onto
main:main.runtime-modernisation.playwright-model-expansion.This PR brings the reviewed content of #17 and #18 into
main. It adds no new code..github/workflows/benchmark.yml), the suite runner, the collector, the Pages dashboard (bench-site/), and the docs (docs/benchmarks.md,docs/benchmark-action.md).playwright-model-expansioncontainsbenchmark-action, andgit merge-treeagainstmainshows no conflicts. The only commit onmainthat this branch lacks is the merge commit of #16.After merge,
benchmarkappears under Actions. Seedocs/benchmark-action.mdfor the one-time setup before the first run.🤖 Generated with Claude Code
https://claude.ai/code/session_01ERiF61xcNaEQNrhaQZvdyq