Repository navigation
Merge the nine audit fix branches - #10
Open
KARLalpha4768 wants to merge 18 commits into
Open
KARLalpha4768 wants to merge 18 commits into
KARLalpha4768 wants to merge 18 commits into
Conversation
…d longitude (PERF-01, CORR-06)
…Kepler solver (CORR-07, CORR-08)
…d updates (CORR-10)
… test production orbit code (ARCH-01, DEPLOY-04, CI-01, TEST-01)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
One branch that merges the nine fix branches behind PRs #1 to #9 (open since Oct 25), so they can be reviewed and merged together instead of one at a time. No file is touched by more than one of them, and all nine merged without conflicts. Nothing here is new work: each merge commit brings in one existing branch unchanged.
fix/secrets-env/api/configfunctionfix/api-nlp-lockdown/api/nlprequires an API key, limits origins, rate-limits and validates inputfix/docker-buildfix/infra-hardeningfix/correctness-highfix/orbit-propagatorfix/twin-wsfix/dbchore/build-test-hygiene.dockerignore, pytest in CI, deduplicated photometry sourceHow the combined branch was checked
Run locally on Python 3.13 with the CI install step (
pip install -r requirements.txt):ruff check . --select=E9,F63,F7,F82: passes, also withascom_hal.pyincluded.pytest -q: 36 passed.python end_to_end_test.py: 6 of 6.python main.py: all exit 0.api/nlp.jsandapi/config.jscalled through a local harness: 503 whenNLP_API_KEYis unset, 401 without or with a wrong key, 403 from another origin, 429 after 20 requests a minute, and/api/configreturns the token from the environment./docs; the command onmainfails withModuleNotFoundError: No module named 'src'. The image itself was not built.Before merging: this changes the live demo
CESIUM_ION_TOKENin Vercel first. The globe now gets its token from/api/config. Without the variable it receives an empty token./api/nlpnow requires anX-API-Keyheader, andfrontend/sentinel_terminal.js(unchanged by any branch) does not send one. Free-text input that the built-in parser does not recognise will show "I didn't understand that" instead of a Gemini reply. Built-in commands are unaffected. If the public demo should keep the fallback, that needs a decision before merge, since a static page cannot hold a secret key.NLP_API_KEYand, if the site is served from another domain,ALLOWED_ORIGINS. Both functions default to allowing onlyhttps://sentinelforge.vercel.app.Not covered
.vercel/project.jsonis still tracked.ascom_hal.pyfrom the lint step; withfix/correctness-highmerged that exclusion is no longer needed.Merging this PR lands the same commits as #1 to #9, so GitHub will mark those nine as merged and their branches can be deleted.
https://claude.ai/code/session_01GQ1LmN35bvwVLnZ9PiewFe
Generated by Claude Code