Conversation
- "Save Picks..." assigned the saved NamedTuple to `picks`, overwriting the global Observable used for picking. After saving once, adding/dragging picks and "Load Picks..." no longer worked until the GUI was restarted. - the native file dialogs are called through the PICK_FILE/SAVE_FILE Refs, so that tests can replace them. By default they are pick_file/save_file. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Member
Author
|
Closing: these changes are already in main via #10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains only the
srcchanges from #10, so that they can go intomainbefore the workshop. It doesn't include the tests or CI.Bug fix
Save Picks... assigned the NamedTuple it saves to
picks, the name of the global Observable that holds the picks. After saving once:picks[]fails on a NamedTuple)@asynctaskOnly restarting the GUI helped. The fix renames the variable to
pick_data. The saved jld2 file is unchanged: it still has the keyspicks,pick_infoandprofile_info.File dialog hook
The native file dialogs are now called through
PICK_FILE[]/SAVE_FILE[]. By default these arepick_file/save_file, so nothing changes for users. The tests in #10 swap them for functions that return a fixed filename.Testing
The tests in #10 run exactly this code, and they pass on Julia 1.10, 1.11, 1.12 and the latest release on Linux, Windows and macOS. On macOS only the loading checks run.
🤖 Generated with Claude Code