Skip to content

Remove singleton dimensions in compute_to_zarr - #610

Open
felixcremer wants to merge 1 commit into
mainfrom
fc/singletondims
Open

Remove singleton dimensions in compute_to_zarr#610
felixcremer wants to merge 1 commit into
mainfrom
fc/singletondims

Conversation

@felixcremer

Copy link
Copy Markdown
Member

We remove singleton dimensions which we might had to include to allow the DiskArrayEngine algorithm to track them before saving the data to zarr.

We have to remove these singleton dimensions because zarr can't have the same dimensions in a group with different length.

We remove singleton dimensions which we might had to include to allow the DiskArrayEngine algorithm to track them before saving the data to zarr.
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.74%. Comparing base (3a9f5d7) to head (c84a756).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/DAT/xmap.jl 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   69.66%   69.74%   +0.08%     
==========================================
  Files          15       15              
  Lines        2212     2228      +16     
==========================================
+ Hits         1541     1554      +13     
- Misses        671      674       +3     
Files with missing lines Coverage Δ
src/DAT/xmap.jl 56.10% <83.33%> (+1.40%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lazarusA

lazarusA commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

let's merge and patch release this, although it will be nice to have a look from @meggart

@lazarusA
lazarusA requested a review from meggart September 4, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants