Remove singleton dimensions in compute_to_zarr - #610
Open
felixcremer wants to merge 1 commit into
Open
Conversation
We remove singleton dimensions which we might had to include to allow the DiskArrayEngine algorithm to track them before saving the data to zarr.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 69.66% 69.74% +0.08%
==========================================
Files 15 15
Lines 2212 2228 +16
==========================================
+ Hits 1541 1554 +13
- Misses 671 674 +3
🚀 New features to boost your workflow:
|
Collaborator
|
let's merge and patch release this, although it will be nice to have a look from @meggart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove singleton dimensions which we might had to include to allow the DiskArrayEngine algorithm to track them before saving the data to zarr.
We have to remove these singleton dimensions because zarr can't have the same dimensions in a group with different length.