Repository navigation
Move the top-level test files that mirror no source file - #36
Merged
Merged
Conversation
The test convention keeps a test file at the top level of test/ only where it mirrors src/<name>.jl. Each moved file keeps its label and group in test/runtests.jl. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Both sides add an entry under [Unreleased] in CHANGELOG.md; both are kept. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 9 9
Lines 1162 1162
=======================================
Hits 1059 1059
Misses 103 103 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The test files at the top level of
test/that mirror no source file move to where the test convention puts them:test/<path>.jlfor a test ofsrc/<path>.jl, the directory of the sources for a test of several files of one directory, andtest/integration/for a test of the whole package. Each file keeps its label and group; only its path intest/runtests.jlchanges.test/basis.jltest/integration/basis.jlChecks
run-tests.jl liston this branch and onmain: labels and groups equal line for line; only the paths of the moved files differ.run-tests.jl full --jobs 4on this branch and onmain: both pass with the same totals over all files. Each moved file, run alone onmainat its old path and here at its new path, gives the same totals for its label (Clamped and Recombined Basis Tests (basis.jl -> integration/basis.jl): Pass 58142 Fail 0 Error 0 Broken 0 Total 58142).test/integration/basis.jlis unchanged (the file has no include orjoinpath(@__DIR__, ...)).Open pull requests that also change files under
test/: Move the doctests into their own test group #35 Move the doctests into their own test group. The later one to merge rebases.🤖 Generated with Claude Code