[michakraus]

Finding

fatou 0.22.0 (fatou lint --output json src test) reports two findings on main (02cab5b), both unused-binding, on test/tensorproduct.jl:287:

x1, x2 = quadrature_nodes(q), quadrature_weights(q)

• local variable x1 is assigned but never used
• local variable x2 is assigned but never used

Fix

The line is deleted. The next two lines bind the same values as X1, X2 = quadrature_nodes(q) and W1, W2 = quadrature_weights(q), and the testset reads only those. Both right-hand sides are side-effect-free accessors, so the deletion changes no behaviour. No rename to _ and no suppression. No source file changes.

Evidence

• fatou 0.22.0 before: the two unused-binding findings above. After: [] (checked 23 file(s): clean).
• test/tensorproduct.jl (the "Tensor products" testset): 408/408 pass before the edit and 408/408 after, so no @test was lost.
• core group: 65122/65122 pass.

Pre-PR verification

Fixed: none.

Unresolved: none.

Pre-existing:

• nit: the [Unreleased] section has only ### New Features, so this test cleanup is listed there, next to the earlier test-infrastructure entries.

Checked and clean:

• Correctness: the deleted x1, x2 = quadrature_nodes(q), quadrature_weights(q) bound names that nothing uses. Both callees are pure accessors, so the deletion removes no side effect. The testset already binds the same values as X1, X2 and W1, W2.
• fatou 0.22.0: the base reports unused-binding for x1 and x2 at test/tensorproduct.jl:287. The branch reports none ([]).
• JuliaFormatter (sciml), NFC normalisation and the test-layout check pass on the changed files.
• Allocations: the change only deletes code. fatou lint is clean.
• Comments: the comment next to the hunk is still accurate.
• CHANGELOG: an entry is present under [Unreleased]. No history phrases appear outside CHANGELOG.md.
• Tests: test/tensorproduct.jl passes 408/408 before and after the edit. The core group passes 65122/65122.

Not checked:

• Type piracy (Aqua) and type stability: no src/ line and no method definition changed, so no finding could come from this diff.

🤖 Generated with Claude Code

[Copilot]

Copilot review overview

🟢 Approval recommended

The deleted expressions duplicate side-effect-free accessor calls whose results remain correctly bound below.

Review effort: Balanced
Findings: None

What changed in this PR

Removes redundant test bindings flagged by fatou without changing behavior.

Changes:

• Deletes unused quadrature accessor results.
• Documents the cleanup in the changelog.

File	Description
test/​tensorproduct.jl	Removes unused bindings.
CHANGELOG.md	Records the cleanup.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️