[Fix] 모의지원 홈 응답에 자소서 채점중 여부 추가 - #231
Conversation
- MockApply 홈 카드 응답에 analysisInProgress 필드 추가 - PENDING/RUNNING 분석 비동기 작업 기준으로 채점중 여부 계산 - 홈/최근/검색 목록에서 동일한 채점중 플래그를 내려주도록 수정 - 홈 목록 응답의 채점중 상태 검증 테스트 추가
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughMockApply 목록 응답에 ChangesMockApply 분석 진행 상태 표시
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MockApplyService
participant AnalysisAsyncTaskRepository
participant MockApplyHomeItemResponse
MockApplyService->>AnalysisAsyncTaskRepository: 활성 분석 작업 조회
AnalysisAsyncTaskRepository-->>MockApplyService: PENDING/RUNNING MockApply ID 반환
MockApplyService->>MockApplyHomeItemResponse: 상태 플래그와 MockApply 전달
MockApplyHomeItemResponse-->>MockApplyService: 목록 응답 항목 반환
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java (1)
346-393: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
RUNNING상태도 검증하세요.현재는
PENDING태스크만 저장합니다.TaskStatus.RUNNING이 조회 조건에서 빠지거나 잘못 매핑돼도 테스트가 통과하므로, 동일 카드가analysisInProgress=true가 되는 RUNNING 케이스를 추가하세요.As per path instructions,
src/test/**/*.java에서는 비동기 시나리오를 충분히 검증해야 합니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java` around lines 346 - 393, Update the test around MockApplyServiceTest’s getMyMockApplies scenario to also persist an AnalysisAsyncTask with TaskStatus.RUNNING for a mock apply and assert that the corresponding response item has analysisInProgress=true. Keep the existing PENDING coverage and ensure the RUNNING task uses the same card relationship and lookup conditions as production.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/jobdri/jobdri_api/domain/analysis/repository/AnalysisAsyncTaskRepository.java`:
- Around line 20-24: findByUserIdAndMockApplyIdInAndStatusIn 쿼리의 접근 패턴을 지원하도록 배포
스키마에 user_id, mock_apply_id, status 순서의 복합 인덱스를 추가하세요. 기존 단일 또는 created_at 포함
인덱스와 중복되지 않도록 마이그레이션에 반영하고, 해당 인덱스가 실제 배포 스키마에 생성되는지 검증하세요.
---
Outside diff comments:
In
`@src/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java`:
- Around line 346-393: Update the test around MockApplyServiceTest’s
getMyMockApplies scenario to also persist an AnalysisAsyncTask with
TaskStatus.RUNNING for a mock apply and assert that the corresponding response
item has analysisInProgress=true. Keep the existing PENDING coverage and ensure
the RUNNING task uses the same card relationship and lookup conditions as
production.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7ff09281-eccf-4ff8-b314-d2ad3f072dbc
📒 Files selected for processing (4)
src/main/java/com/jobdri/jobdri_api/domain/analysis/repository/AnalysisAsyncTaskRepository.javasrc/main/java/com/jobdri/jobdri_api/domain/mockapply/dto/response/MockApplyHomeItemResponse.javasrc/main/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyService.javasrc/test/java/com/jobdri/jobdri_api/domain/mockapply/service/MockApplyServiceTest.java
- analysisInProgress 조회 패턴을 위한 analysis_async_tasks 복합 인덱스 추가 - 운영 수동 migration과 schema.sql에 동일 인덱스 반영 - PENDING/RUNNING 분석 작업 모두 홈 응답에서 채점중으로 내려가도록 테스트 보강
1 participant
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [ ]
Summary by CodeRabbit
새로운 기능
버그 수정