Repository navigation
Run the project's own Action on pull requests - #2
Merged
Merged
Conversation
The README tells people to write uses: JingYu-create520/sql-index-advisor@v0 while the changelog admitted the Action had never run as a check on a real pull request. This workflow is that run, against a demo mapper carrying four known problems. The fixture is named demo-schema.json because schema.json is gitignored on purpose: it is user output, not source.
JingYu-create520
added a commit
that referenced
this pull request
Sep 22, 2026
npm prepares a git dependency inside a throwaway clone, and on a clean runner the dev toolchain is not there, so the hook died with "tsup: not found" and the documented install command failed with exit 127. Our own review workflow caught it on pull request #2. The bundle is now committed, prepare rebuilds only when tsup is present, and CI rebuilds and fails if dist drifts from src, then installs the package into an empty project so a stranger's install path is exercised before we ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README tells people to write
uses: JingYu-create520/sql-index-advisor@v0, and the changelog has been honest that this Action had never run as a check on a real pull request. This PR is that run: the published tag, on a GitHub runner, reviewing a mapper added here.What is in it
.github/workflows/index-review.yml—uses: JingYu-create520/sql-index-advisor@v0,min-severity: info,fail-on: off. It comments, it does not gate, so a team can adopt it without their builds going red.examples/pr-demo/OrderSearchDao.xml— four statements, each carrying one known problem, plusdemo-schema.jsonso the schema-dependent rules have something to compare against.Expected annotations
SIA001for the join key and the un-indexed sort column,SIA004forDATE(create_time)and for the leading-wildcardLIKE,SIA006for the literalLIMIT 120000, 20.