Skip to content

feat(search): highlight the hit's words in the item it opens - #73

Merged
JasprW merged 1 commit into
mainfrom
feat/search-highlight
Oct 27, 2026
Merged

JasprW merged 1 commit into
mainfrom
feat/search-highlight

Conversation

@JasprW

@JasprW JasprW commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Spec: DRAWER-SPEC "Focus from search" items 6–7, SEARCH-SPEC §5.3.

  • The focus request carries the hit's field and matched words (termsOfHit, shared with the daemon's matchRanges in shared/search-text.ts).
  • Only the targeted item marks them (bold accent, as in the snippets). The marks stay until the sidebar closes, another card opens or another hit is clicked.
  • The targeted item also shows its full text: notes drop the 4-line limit, checks show the command and output, Progress and idea cards open past Show more (Target shows when the hit is in it), artifacts show the unclipped title and note plus the full link or path, and a closed idea shows the matched field.
  • No stored setting is written. No new strings, tips or telemetry.

Checks: npm run typecheck exits 0; npm test has 140 files, 1193 passed and 1 skipped.

The focus request now carries the hit's field and matched words; the targeted
note, check, idea, artifact or Progress card marks them until the sidebar
closes and shows the full text (note line limit lifted, check output shown,
Show more opened, full link or path). DRAWER-SPEC Focus from search 6-7.
@JasprW
JasprW enabled auto-merge (squash) October 27, 2026 06:57
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@JasprW
JasprW merged commit ab1f8e4 into main Oct 27, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant