Repository navigation
feat(search): a hit opens the card at its section and item - #72
Merged
Merged
Conversation
A search hit row now opens the card's sidebar at the matching section (summary: Progress, note: Activity, workpad: Workpad, idea: Ideas, artifact: Artifacts), makes the item visible (Activity's last-12 window, Workpad/Artifacts pages, Ideas > Closed), scrolls to it and rings it for a moment. The section opens for this opening only; the stored Starts open choices are untouched. Falls back to the section after 1.5 s. DRAWER-SPEC Focus from search; SEARCH-SPEC 5.3.
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
JasprW
enabled auto-merge (squash)
October 27, 2026 05:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #71 (idea accepted on card 搜索功能). Spec: SEARCH-SPEC §5.3, DRAWER-SPEC "Focus from search".
measureLayoutagainst the scroll content; no animation with Reduce Motion) and rings it with the accentCueRingfor about 1.6 s.refId.Checks:
npm run typecheckexit 0;npm testexit 0 (139 files, 1189 passed, 1 skipped); newclient/drawer-focus-logic.test.tsand a workpadrefIdassertion inserver/search.test.ts. The UI check on Tinylink runs after merge (the installed plugin is linked to the main checkout).