Skip to content

chore: setup mise, pkg-pr-new, OIDC for publication - #716

Open
GauBen wants to merge 7 commits into
mainfrom
chore/js-setup
Open

chore: setup mise, pkg-pr-new, OIDC for publication#716
GauBen wants to merge 7 commits into
mainfrom
chore/js-setup

Conversation

@GauBen

@GauBen GauBen commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

In an effort to unify setup across 6 JS repos:

  • mise manages yarn and node locally
  • chachalog config
  • normalize gitignores, remove npm leftovers
  • mise in ci and pinned actions
  • update jahia-modules-action
  • pkg-pr-new, normalized npm publication
  • yarn 4.18 in tests

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

Copilot AI review requested due to automatic review settings August 7, 2026 11:25
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🦜 Chachalog

No changelog entries detected. Learn more about Chachalog.

Create a new entry online or run npx [email protected] prompt to create a new entry locally.

@GauBen GauBen added the 🗒️ no-changelog No release notes or changelog entry should be added for this PR or Issue label Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the JavaScript toolchain and publication workflow for the monorepo by moving Node/Yarn management to mise, aligning Yarn 4 usage, and modernizing CI publication (preview + npm with OIDC).

Changes:

  • Switched Maven builds from frontend-maven-plugin to exec-maven-plugin to run yarn/node commands against the mise-managed toolchain.
  • Added pkg-pr-new preview publishing workflow and introduced an npm publish job intended to use OIDC/provenance.
  • Added .chachalog configuration and bumped/normalized Yarn 4.18 usage (notably in tests), along with gitignore/yarnrc adjustments.

Reviewed changes

Copilot reviewed 19 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Adds new dev dependencies lock entries (@chachalog/types, pkg-pr-new).
package.json Adds dev dependencies for chachalog typing and preview publishing tooling.
mise.toml Pins Node/Yarn toolchain via mise.
pom.xml Removes frontend-maven-plugin management and bumps/standardizes exec-maven-plugin usage.
javascript-modules-engine/pom.xml Migrates Yarn execution to exec-maven-plugin; adjusts release-prepare behavior.
javascript-modules-library/pom.xml Migrates Yarn execution to exec-maven-plugin; removes alpha publish steps.
javascript-create-module/pom.xml Migrates Yarn execution to exec-maven-plugin; removes alpha publish steps.
vite-plugin/pom.xml Migrates Yarn and version sync execution to exec-maven-plugin.
jahia-test-module/pom.xml Migrates Yarn execution to exec-maven-plugin; version sync via node.
samples/hydrogen/pom.xml Migrates Yarn execution to exec-maven-plugin; version sync via node.
.yarnrc.yml Drops yarnPath and adds npmPreapprovedPackages configuration.
tests/.yarnrc.yml Drops yarnPath and adds npmPreapprovedPackages configuration.
tests/package.json Removes publish script; bumps test packageManager Yarn version to 4.18.0.
tests/yarn.lock Updates lockfile format/version to match newer Yarn.
.gitignore Broadly ignores .yarn/ contents while attempting to keep patches.
.github/workflows/skip-for-docs.yml Removes docs-only skip workflow.
.github/workflows/pkg-pr-new.yml Adds preview publishing workflow using pkg-pr-new.
.github/workflows/on-release.yml Pins actions and adds npm publish job with id-token permission for OIDC/provenance.
.github/workflows/on-merge.yml Pins checkout action; removes explicit npm token setup.
.github/workflows/on-code-change.yml Pins checkout and replaces setup-node with mise for toolchain setup.
.chachalog/config.mjs Adds chachalog configuration backed by .chachalog/.version.
.chachalog/.version Adds initial version file for chachalog-managed versioning.

Comment thread javascript-modules-engine/pom.xml
Comment thread package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗒️ no-changelog No release notes or changelog entry should be added for this PR or Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants