chore: setup mise, pkg-pr-new, OIDC for publication - #716
Open
GauBen wants to merge 7 commits into
Open
Conversation
🦜 ChachalogNo changelog entries detected. Learn more about Chachalog. Create a new entry online or run |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the JavaScript toolchain and publication workflow for the monorepo by moving Node/Yarn management to mise, aligning Yarn 4 usage, and modernizing CI publication (preview + npm with OIDC).
Changes:
- Switched Maven builds from
frontend-maven-plugintoexec-maven-pluginto runyarn/nodecommands against themise-managed toolchain. - Added
pkg-pr-newpreview publishing workflow and introduced an npm publish job intended to use OIDC/provenance. - Added
.chachalogconfiguration and bumped/normalized Yarn 4.18 usage (notably in tests), along with gitignore/yarnrc adjustments.
Reviewed changes
Copilot reviewed 19 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds new dev dependencies lock entries (@chachalog/types, pkg-pr-new). |
| package.json | Adds dev dependencies for chachalog typing and preview publishing tooling. |
| mise.toml | Pins Node/Yarn toolchain via mise. |
| pom.xml | Removes frontend-maven-plugin management and bumps/standardizes exec-maven-plugin usage. |
| javascript-modules-engine/pom.xml | Migrates Yarn execution to exec-maven-plugin; adjusts release-prepare behavior. |
| javascript-modules-library/pom.xml | Migrates Yarn execution to exec-maven-plugin; removes alpha publish steps. |
| javascript-create-module/pom.xml | Migrates Yarn execution to exec-maven-plugin; removes alpha publish steps. |
| vite-plugin/pom.xml | Migrates Yarn and version sync execution to exec-maven-plugin. |
| jahia-test-module/pom.xml | Migrates Yarn execution to exec-maven-plugin; version sync via node. |
| samples/hydrogen/pom.xml | Migrates Yarn execution to exec-maven-plugin; version sync via node. |
| .yarnrc.yml | Drops yarnPath and adds npmPreapprovedPackages configuration. |
| tests/.yarnrc.yml | Drops yarnPath and adds npmPreapprovedPackages configuration. |
| tests/package.json | Removes publish script; bumps test packageManager Yarn version to 4.18.0. |
| tests/yarn.lock | Updates lockfile format/version to match newer Yarn. |
| .gitignore | Broadly ignores .yarn/ contents while attempting to keep patches. |
| .github/workflows/skip-for-docs.yml | Removes docs-only skip workflow. |
| .github/workflows/pkg-pr-new.yml | Adds preview publishing workflow using pkg-pr-new. |
| .github/workflows/on-release.yml | Pins actions and adds npm publish job with id-token permission for OIDC/provenance. |
| .github/workflows/on-merge.yml | Pins checkout action; removes explicit npm token setup. |
| .github/workflows/on-code-change.yml | Pins checkout and replaces setup-node with mise for toolchain setup. |
| .chachalog/config.mjs | Adds chachalog configuration backed by .chachalog/.version. |
| .chachalog/.version | Adds initial version file for chachalog-managed versioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In an effort to unify setup across 6 JS repos:
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review